MIME-Version: 1.0
References: <5831447.lOV4Wx5bFT@natalenko.name>
In-Reply-To: <5831447.lOV4Wx5bFT@natalenko.name>
From:   Marios Makassikis <mmakassikis@freebox.fr>
Date:   Wed, 17 Nov 2021 00:03:34 +0100
Message-ID: <CAF6XXKXKivX-_OR+ZtqQP4yMVtJ=rGTPWvBDQSdys1vTCBHKUw@mail.gmail.com>
Subject: Re: ksmbd: Unsupported addition info
To:     Oleksandr Natalenko <oleksandr@natalenko.name>
Cc:     Namjae Jeon <linkinjeon@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        Hyunchul Lee <hyc.lee@gmail.com>,
        CIFS <linux-cifs@vger.kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 16, 2021 at 10:44 PM Oleksandr Natalenko
<oleksandr@natalenko.name> wrote:
>
> Hello Namjae et al.
>
> With the latest ksmbd from the next branch I have an issue with wife's Wi=
ndows
> 10 laptop while copying/removing files from the network share. On her cli=
ent it
> looks like copy operation (server -> laptop) reaches 99% and then stalls,=
 and
> on the server side there's this in the kernel log:
>
> ```
> ksmbd: Unsupported addition info: 0xf)
> ksmbd: Unsupported addition info: 0x20)
> ```
>
> repeated multiple times. I must note that in fact the file gets copied to=
 her
> laptop, but Windows copy dialog just hangs.
>
> Any idea what it could be and how to avoid it? This also happened before =
(I'm
> a pretty early ksmbd adopter), but I'm reporting it just now because I na=
=C3=AFvely
> hoped it would be fixed automagically :). This never happened to me with
> userspace Samba though.
>
> This is my smb.conf:
>
> ```
> [global]
> workgroup =3D KANAPKA
> server string =3D ksmbd server %v
> netbios name =3D defiant
> valid users =3D __guest
>
> [Shared]
> valid users =3D __guest
> path =3D /mnt/shared
> force user =3D _shared
> force group =3D _shared
> browsable =3D no
> writeable =3D yes
> veto files =3D /lost+found/
> ```
>
> Appreciate your time and looking forward to your response.
>
> Thanks.
>

Hello,

This sounds like an issue reported on github a couple of months ago [1].

Can you specify the exact Windows version (+ edition) ?

Are you accessing the share through a network-mapped drive ? If not,
can you try to reproduce it ?

Does this happen with files of any type ? IIRC, the "Unsupported addition i=
nfo"
message you're seeing is related to Windows requesting some attributes
that are not handled yet by ksmbd. It seems it was added to fix
windows 10 clients
after ACLs support was added [2]. Makes me wonder if Windows doesn't like t=
he
fake response it is getting when it's trying to read the SACLs.

https://github.com/cifsd-team/ksmbd-tools/issues/208
https://github.com/namjaejeon/ksmbd/commit/cb9167856ffca6483

> --
> Oleksandr Natalenko (post-factum)
>
>