Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D41BC433F5 for ; Wed, 17 Nov 2021 01:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0974161507 for ; Wed, 17 Nov 2021 01:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbhKQB7G (ORCPT ); Tue, 16 Nov 2021 20:59:06 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:52506 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhKQB7F (ORCPT ); Tue, 16 Nov 2021 20:59:05 -0500 Received: from fsav411.sakura.ne.jp (fsav411.sakura.ne.jp [133.242.250.110]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 1AH1u6TG056219; Wed, 17 Nov 2021 10:56:06 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav411.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav411.sakura.ne.jp); Wed, 17 Nov 2021 10:56:06 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav411.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 1AH1tl6l055695 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Wed, 17 Nov 2021 10:56:06 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Message-ID: Date: Wed, 17 Nov 2021 10:55:44 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 From: Tetsuo Handa Subject: Re: [PATCH] vt: Fix sleeping functions called from atomic context To: "Fabio M. De Francesco" Cc: syzbot+5f47a8cea6a12b77a876@syzkaller.appspotmail.com, Marco Elver , Greg Kroah-Hartman , Jiri Slaby , Max Filippov , David Sterba , Bhaskar Chowdhury , Igor Matheus Andrade Torrente , nick black , linux-kernel@vger.kernel.org References: <20211116144937.19035-1-fmdefrancesco@gmail.com> Content-Language: en-US In-Reply-To: <20211116144937.19035-1-fmdefrancesco@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/11/16 23:49, Fabio M. De Francesco wrote: > - if (in_interrupt()) > + if (!preemptible()) > return count; preemptible() is "an unconditional 0" if CONFIG_PREEMPT_COUNT=n . Is preemptible() really what we want? ;-)