From:   Meng Li <Meng.Li@windriver.com>
To:     thor.thayer@linux.intel.com, lee.jones@linaro.org, arnd@arndb.de
Cc:     linux-kernel@vger.kernel.org, meng.li@windriver.com
Subject: [PATCH v3] mfd: altera-sysmgr: enable raw spinlock feature for preempt-rt kernel
Date:   Wed, 17 Nov 2021 11:49:03 +0800
Message-Id: <20211117034903.28588-1-Meng.Li@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OEkohnxLj0Jr1/D9BSvXuuooAQhKHh947xDZ/pis9wfDWTKau0+S6fMQ8ARZ?=
 =?us-ascii?Q?kd9eYo6OMu8EO6wIm+mBxHtzYMvTtogWQm7tozLYaXlxD1ypYhcbQ6p3g2cB?=
 =?us-ascii?Q?qxh3pdnW32Z1XSBGNRiECpYu12qw04qnQIHqO6D+MtuxJoAAWGNAaREuCqQK?=
 =?us-ascii?Q?HwY7YKvhd2UdMad+2Kbbtm7tGhUtqyJPyzx/srMs1APNAy+/Gi8lMGyoq9o4?=
 =?us-ascii?Q?biJRyBvjTK/H2ea5gzHUbwx+9YrMGjpBrkl2weeOB0KcsABJeUTWwU6QmeA8?=
 =?us-ascii?Q?5rhC5dKC7/VPySBiSEAiAtlmMUFD10e77tbykwkEem463iUkMuGooETDHy1T?=
 =?us-ascii?Q?xHOh1GgtQF8txEXkv49OnRjeFpsuoJCTfq8gOQ3dCSTjeXI1gxER9tcSb4wr?=
 =?us-ascii?Q?gYtuH/7H+D0nr2Z2bPVk3nDrip+FEk/lWrlHhkHmQN9chN/NAtXP2DSceiDN?=
 =?us-ascii?Q?BxzTEjyak7qldjZdErgmC/hFjOiIxBr2AAZ/ABM0VL625aKvSmJW/wUnIVuC?=
 =?us-ascii?Q?a62f/vnW8DhLgywJAmU3ZLiPMzrl8rS6WeFTSV6q9RDn7XnsE/qGwqcPcID6?=
 =?us-ascii?Q?fp2l0Bj+AuOwJxQIxaXYLj+KmYAnneXP9NpGAuqA44Gqt6bzvT/yaW1LAhRk?=
 =?us-ascii?Q?BSHtvNH64zLSIIEYKRNxTF3ycmNxXN4av4ZHmZSL3c0xVGiae79WhehuUmjM?=
 =?us-ascii?Q?Yo3qbWY0EEzSbYbNtBotpipnLPUBanhwQkP/WKdKBd5kM/D26WS9h01ay9bY?=
 =?us-ascii?Q?PukxaWoNeI2UIqJVizsvXxoTMTTuvHlulX/SScumZmx5GvbLkufMnqyYUXO7?=
 =?us-ascii?Q?tWgNqKko9PmdK4/stnHnkqUx5kUR+60m3SRNYm4u2XiajZv+37KiXT/TMcKG?=
 =?us-ascii?Q?kbDyuGGNiTA+VW0v+vo7D5MbwlUrTd5FUYDNuF0EHKwQshEgo5mpOF0438E3?=
 =?us-ascii?Q?dPurbiXSemv/xu/x3q1X+SHV4gPudZGgblStNZPFu7frgOQ8heBVyp8lINJ0?=
 =?us-ascii?Q?mDXXUuUCRgpviTvzCdvH+CZ7kxRYbgZDGw+r5PmbZgeFXwoyDjbHdZitZDig?=
 =?us-ascii?Q?AIE2n1+6CtV9B6EFa9Ed+ptzXEPdfIbkF/g7udjlsr5CqbXOfju541azC8A2?=
 =?us-ascii?Q?mMdFRNII471Bsx/TbRnYaVA5ni3wlHa8z24WRJSHhsxd0qOWgLbK8KVjC+Mw?=
 =?us-ascii?Q?W1xgYuv6ZlP7PHL7KoXud7QKFN4FMpt1/G5ugVTQhLFBnoEDJtfpMwQqI92Y?=
 =?us-ascii?Q?RbnaZUWHyQ2EwLlyxcgG7SmRJ0Gjqausf3VGBQSvxnuRi7+vkS1NyvsrySW0?=
 =?us-ascii?Q?1q0j/Wi/2mcIkJ/DI5aJeM1x8TtUPMkLK/Oy4HeZQTDBpjPLQrd4Ih7ATd0d?=
 =?us-ascii?Q?ytDTNOykmf9tL9yXOTa9T8MUfbRKCbKRUEvJpSt7x3DliVQfoH+wULrzZI8h?=
 =?us-ascii?Q?GN/e5WWgO/I13ln5TPBfYlHPITzat5mQgqRC4BYrVI8phm6ppRGBgEYrPmu6?=
 =?us-ascii?Q?bGrxWFoUHBRU9+z4jKbNiNov21vJKeBElu/eBe71QjiFV9axsU9ErHU4V41R?=
 =?us-ascii?Q?5EPMb13F4FASA6RlQO3rHrxW2FkOm7+ACHLmqja1wl3v+4soe+HqJmU+oYYH?=
 =?us-ascii?Q?gTlZktgmp0zXj1Ip+qDam2M=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 129a9928-394b-46dd-7256-08d9a97d3bfa
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 03:49:19.3932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Hx08OHNZhMe6yD6ekyZol1ojWFJM/T3nNMzajU2EuAimNMABrqaA2xxNk2zY4Pu6mALL/UOBdm2nsnzZ4Lrow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5206
X-Proofpoint-ORIG-GUID: vS7hBJHGmPt1LfBaNhIGqyTndjWrHFjj
X-Proofpoint-GUID: vS7hBJHGmPt1LfBaNhIGqyTndjWrHFjj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-17_01,2021-11-16_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 malwarescore=0 clxscore=1015 adultscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0
 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2111170016
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When booting up preempt rt kernel on stratix10 platform, there is
below calltrace:
BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 1, name: swapper/0
Preemption disabled at:
[<ffff8000100b25b0>] __setup_irq+0xe0/0x730
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.78-rt54-yocto-preempt-rt #1
Hardware name: SoCFPGA Stratix 10 SoCDK (DT)
Call trace:
 ......
 ___might_sleep+0x144/0x180
 rt_spin_lock+0x34/0x9c
 regmap_lock_spinlock+0x24/0x40
 regmap_write+0x48/0x84
 a10_eccmgr_irq_unmask+0x34/0x40
 ......
 altr_edac_a10_probe+0x16c/0x2b0
 platform_drv_probe+0x60/0xb4
 ......
 ret_from_fork+0x10/0x38

Because regmap_write is invoked under preemption disabled status, and
might trigger sleep.
Recently, the commit 67021f25d952("regmap: teach regmap to use raw
spinlocks if requested in the config ") add an option for regmap to use
raw spinlock. So, enable raw spinlock in preempt-rt kernel to avoid the
might sleep issue.
Note: The commit 67021f25d952 is only in kernel v5.15, not included in
earlier versions. So, if intend to fix this issue in earlier preempt-rt
kernel, it is need to backport the 2 patches together, otherwise there
will be building issue.

Signed-off-by: Meng Li <Meng.Li@windriver.com>
---

v3:
 - remove #ifdef CONFIG_PREEMPT_RT

v2:
 - improve the patch title.
 - improve the commit log. Clear which commit is depended by this patch.

---
 drivers/mfd/altera-sysmgr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
index 5d3715a28b28..ac350b4ca486 100644
--- a/drivers/mfd/altera-sysmgr.c
+++ b/drivers/mfd/altera-sysmgr.c
@@ -83,6 +83,7 @@ static struct regmap_config altr_sysmgr_regmap_cfg = {
 	.fast_io = true,
 	.use_single_read = true,
 	.use_single_write = true,
+	.use_raw_spinlock = true,
 };
 
 /**
-- 
2.17.1