Subject: Re: linux-next: Tree for Nov 17 (uml, no IPV6)
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Netdev <netdev@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
References: <20211117135800.0b7072cd@canb.auug.org.au>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <268ae204-efae-3081-a5dd-44fc07d048ba@infradead.org>
Date:   Tue, 16 Nov 2021 21:46:35 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211117135800.0b7072cd@canb.auug.org.au>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/16/21 6:58 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20211116:
> 

ARCH=um SUBARCH=x86_64:
# CONFIG_IPV6 is not set


In file included from ../net/ethernet/eth.c:62:0:
../include/net/gro.h: In function ?ip6_gro_compute_pseudo?:
../include/net/gro.h:413:22: error: implicit declaration of function ?csum_ipv6_magic?; did you mean ?csum_tcpudp_magic?? [-Werror=implicit-function-declaration]
   return ~csum_unfold(csum_ipv6_magic(&iph->saddr, &iph->daddr,
                       ^~~~~~~~~~~~~~~
                       csum_tcpudp_magic


After I made ip6_gro_compute_pseudo() conditional on CONFIG_IPV6,
I got this build error:

In file included from ../net/ipv6/tcpv6_offload.c:10:0:
../net/ipv6/tcpv6_offload.c: In function ?tcp6_gro_receive?:
../net/ipv6/tcpv6_offload.c:22:11: error: implicit declaration of function ?ip6_gro_compute_pseudo?; did you mean ?inet_gro_compute_pseudo?? [-Werror=implicit-function-declaration]
            ip6_gro_compute_pseudo)) {
            ^
../include/net/gro.h:235:5: note: in definition of macro ?__skb_gro_checksum_validate?
      compute_pseudo(skb, proto));  \
      ^~~~~~~~~~~~~~
../net/ipv6/tcpv6_offload.c:21:6: note: in expansion of macro ?skb_gro_checksum_validate?
       skb_gro_checksum_validate(skb, IPPROTO_TCP,
       ^~~~~~~~~~~~~~~~~~~~~~~~~


This is UML x86_64 defconfig:

$ make ARCH=um SUBARCH=x86_64 defconfig all


-- 
~Randy