MIME-Version: 1.0
References: <20211115031817.4193-1-bernard@vivo.com>
In-Reply-To: <20211115031817.4193-1-bernard@vivo.com>
From:   Song Liu <song@kernel.org>
Date:   Tue, 16 Nov 2021 23:06:21 -0800
Message-ID: <CAPhsuW6ui=wBrToYkqEOpLyLYhjHMoy0mL0UMcXnq0ObKLLhoA@mail.gmail.com>
Subject: Re: [PATCH] drivers/md: fix potential memleak
To:     bernard@vivo.com
Cc:     linux-raid <linux-raid@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Nov 14, 2021 at 7:18 PM Bernard Zhao <bernard@vivo.com> wrote:
>
> In function get_bitmap_from_slot, when md_bitmap_create failed,
> md_bitmap_destroy must be called to do clean up.

Could you please explain which variable(s) need clean up?

Thanks,
Song

>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/md/md-bitmap.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index bfd6026d7809..a227bd0b9301 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -1961,6 +1961,7 @@ struct bitmap *get_bitmap_from_slot(struct mddev *mddev, int slot)
>         bitmap = md_bitmap_create(mddev, slot);
>         if (IS_ERR(bitmap)) {
>                 rv = PTR_ERR(bitmap);
> +               md_bitmap_destroy(mddev)
>                 return ERR_PTR(rv);
>         }
>
> --
> 2.33.1
>