MIME-Version: 1.0
References: <20211116012317.69456-1-dave@stgolabs.net>
In-Reply-To: <20211116012317.69456-1-dave@stgolabs.net>
From:   Song Liu <song@kernel.org>
Date:   Tue, 16 Nov 2021 23:35:33 -0800
Message-ID: <CAPhsuW7w9e2xNwacStU_Km9Q8evP5DcVatF8fW1DnKxJJ0L3NA@mail.gmail.com>
Subject: Re: [PATCH] md/raid5: play nice with PREEMPT_RT
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     linux-raid <linux-raid@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Davidlohr Bueso <dbueso@suse.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 15, 2021 at 5:23 PM Davidlohr Bueso <dave@stgolabs.net> wrote:
>
> raid_run_ops() relies on the implicitly disabled preemption for
> its percpu ops, although this is really about CPU locality. This
> breaks RT semantics as it can take regular (and thus sleeping)
> spinlocks, such as stripe_lock.
>
> Add a local_lock such that non-RT does not change and continues
> to be just map to preempt_disable/enable, but makes RT happy as
> the region will use a per-CPU spinlock and thus be preemptible
> and still guarantee CPU locality.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

Applied to md-next.

Thanks,
Song