MIME-Version: 1.0
References: <20211117135800.0b7072cd@canb.auug.org.au> <268ae204-efae-3081-a5dd-44fc07d048ba@infradead.org>
In-Reply-To: <268ae204-efae-3081-a5dd-44fc07d048ba@infradead.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 17 Nov 2021 09:44:41 +0100
Message-ID: <CAMuHMdUdA6cJkWWKypvn7nGQw+u=gW_oRNWB-=G8g2T3VixJFQ@mail.gmail.com>
Subject: Re: linux-next: Tree for Nov 17 (uml, no IPV6)
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Netdev <netdev@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Randy,

On Wed, Nov 17, 2021 at 6:49 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 11/16/21 6:58 PM, Stephen Rothwell wrote:
> > Changes since 20211116:
>
> ARCH=um SUBARCH=x86_64:
> # CONFIG_IPV6 is not set

It doesn't always happen with CONFIG_IPV6=n, so I guess that's why
it wasn't detected before.

> In file included from ../net/ethernet/eth.c:62:0:
> ../include/net/gro.h: In function ‘ip6_gro_compute_pseudo’:
> ../include/net/gro.h:413:22: error: implicit declaration of function ‘csum_ipv6_magic’; did you mean ‘csum_tcpudp_magic’? [-Werror=implicit-function-declaration]
>    return ~csum_unfold(csum_ipv6_magic(&iph->saddr, &iph->daddr,
>                        ^~~~~~~~~~~~~~~
>                        csum_tcpudp_magic
>
>
> After I made ip6_gro_compute_pseudo() conditional on CONFIG_IPV6,
> I got this build error:
>
> In file included from ../net/ipv6/tcpv6_offload.c:10:0:
> ../net/ipv6/tcpv6_offload.c: In function ‘tcp6_gro_receive’:
> ../net/ipv6/tcpv6_offload.c:22:11: error: implicit declaration of function ‘ip6_gro_compute_pseudo’; did you mean ‘inet_gro_compute_pseudo’? [-Werror=implicit-function-declaration]
>             ip6_gro_compute_pseudo)) {
>             ^
> ../include/net/gro.h:235:5: note: in definition of macro ‘__skb_gro_checksum_validate’
>       compute_pseudo(skb, proto));  \
>       ^~~~~~~~~~~~~~
> ../net/ipv6/tcpv6_offload.c:21:6: note: in expansion of macro ‘skb_gro_checksum_validate’
>        skb_gro_checksum_validate(skb, IPPROTO_TCP,
>        ^~~~~~~~~~~~~~~~~~~~~~~~~
>
>
>
> This is UML x86_64 defconfig:
>
> $ make ARCH=um SUBARCH=x86_64 defconfig all

noreply@ellerman.id.au reported the same issue for m5272c3_defconfig,
and I've bisected the failure to commit 4721031c3559db8e ("net:
move gro definitions to include/net/gro.h").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds