MIME-Version: 1.0
References: <20211117010527.27365-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20211117010527.27365-2-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAMuHMdWD-bANzURAgksYyZM-u6wPaATiNS-DjVg6NLpk7Stj6g@mail.gmail.com>
In-Reply-To: <CAMuHMdWD-bANzURAgksYyZM-u6wPaATiNS-DjVg6NLpk7Stj6g@mail.gmail.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Wed, 17 Nov 2021 08:57:27 +0000
Message-ID: <CA+V-a8sJoNJuKJ3Hcq8LkZsS7SazywuEOYR3KLPZH117qDk+Rg@mail.gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: spi: renesas,rspi: Document RZ/G2L SoC
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-spi <linux-spi@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Geert,

Thank you for the review.

On Wed, Nov 17, 2021 at 8:51 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, Nov 17, 2021 at 2:05 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > Add RSPI binding documentation for Renesas RZ/G2L SoC.
> >
> > RSPI block is identical to one found on RZ/A, so no driver changes are
> > required the fallback compatible string "renesas,rspi-rz" will be used
>
> ... required. The ...
>
will fix that.

> > on RZ/G2L
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
> > @@ -21,7 +21,8 @@ properties:
> >            - enum:
> >                - renesas,rspi-r7s72100  # RZ/A1H
> >                - renesas,rspi-r7s9210   # RZ/A2
> > -          - const: renesas,rspi-rz     # RZ/A
> > +              - renesas,r9a07g044-rspi # RZ/G2{L,LC}
> > +          - const: renesas,rspi-rz     # RZ/A and RZ/G2{L,LC}
> >
> >        - items:
> >            - enum:
> > @@ -116,6 +117,16 @@ allOf:
> >        required:
> >          - interrupt-names
> >
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - renesas,r9a07g044-rspi
> > +    then:
> > +      required:
> > +        - resets
> > +
>
> You may want to merge this with the existing section that makes
> resets required for renesas,qspi.
>
Right, I completely missed that.

Cheers,
Prabhakar

> >    - if:
> >        properties:
> >          compatible:
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds