Message-ID: <beeecf6d-3cd9-2072-ee7c-13712a77807d@linux.ibm.com>
Date:   Wed, 17 Nov 2021 14:35:29 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next
Content-Language: en-US
To:     Thomas Richter <tmricht@linux.ibm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org, sumanthk@linux.ibm.com, jolsa@redhat.com
Cc:     svens@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com
References: <20211103155215.2941895-1-tmricht@linux.ibm.com>
From:   Madhavan Srinivasan <maddy@linux.ibm.com>
In-Reply-To: <20211103155215.2941895-1-tmricht@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/3/21 21:22, Thomas Richter wrote:
> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> broke the test case 27 (Sample parsing) on s390 on linux-next tree:
>
>    # ./perf test -Fv 27
>    27: Sample parsing
>    --- start ---
>    parsing failed for sample_type 0x800
>    ---- end ----
>    Sample parsing: FAILED!
>    #
>
> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> in above commit.  Correct this define and the test case runs fine.
>
> Output After:
>    # ./perf test -Fv 27
>    27: Sample parsing                                                  :
>    --- start ---
>    ---- end ----
>    Sample parsing: Ok
>    #


Hi Thomas,
Thanks for the fix. Not sure, I guess I messed up my big endian setup or 
test run I had before sending
the patch. My bad. It fails for me too, but with your patch the issue 
fixed.

Acked-and-Tested-by: Madhavan Srinivasan <maddy@linux.ibm.com>


>
> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
>   tools/perf/tests/sample-parsing.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
> index c83a11514129..9c7af55b74db 100644
> --- a/tools/perf/tests/sample-parsing.c
> +++ b/tools/perf/tests/sample-parsing.c
> @@ -36,7 +36,7 @@
>    * These are based on the input value (213) specified
>    * in branch_stack variable.
>    */
> -#define BS_EXPECTED_BE	0xa00d000000000000
> +#define BS_EXPECTED_BE	0xa000d00000000000
>   #define BS_EXPECTED_LE	0xd5000000
>   #define FLAG(s)	s->branch_stack->entries[i].flags
>