MIME-Version: 1.0
References: <20211111084415.663951-1-eranian@google.com> <20211111084415.663951-12-eranian@google.com>
 <689f7b71-32b8-ba0e-22ff-c2248662b1e1@amd.com>
In-Reply-To: <689f7b71-32b8-ba0e-22ff-c2248662b1e1@amd.com>
From:   Stephane Eranian <eranian@google.com>
Date:   Wed, 17 Nov 2021 01:15:25 -0800
Message-ID: <CABPqkBQNpFUGm0Eu3KtPwex1r7G5C0yp-F+fsjiS+2KJ0uuRqQ@mail.gmail.com>
Subject: Re: [PATCH v2 11/13] perf tools: improve IBS error handling
To:     Kim Phillips <kim.phillips@amd.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com,
        mpe@ellerman.id.au, maddy@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Kim,

On Tue, Nov 16, 2021 at 8:46 AM Kim Phillips <kim.phillips@amd.com> wrote:
>
> On 11/11/21 2:44 AM, Stephane Eranian wrote:
> > From: Kim Phillips <kim.phillips@amd.com>
> >
> > This patch improves the error message returned on failed perf_event_open() on
> > AMD when using IBS.
> >
> > Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> > ---
>
> Hi, AFAICT this v2 == v1, i.e., this patch doesn't address the comments
> raised in v1:
>
> https://lore.kernel.org/lkml/aa40b532-0e95-76c0-6c9c-a91d45bf3468@amd.com/
>
> Arnaldo, orthogonal to this series, it'd be great if you could apply
> these two patches:
>
> https://lore.kernel.org/lkml/20211004214114.188477-1-kim.phillips@amd.com/T/#mc4c9c582e3816ab31af6d0187e6803de1a98ac84
>
I don't understand why this patch is related to the IBS error
handling. Patch 11/13 does not modify the evsel__env() function.
I have included your change in the new version of the patch.
Thanks.


> Then, Stephane, you could drop this patch and in your next
> version, patch 12/13 of this series would be replaced with
> what's at the end of this email:
>
> https://lore.kernel.org/lkml/20211004214114.188477-1-kim.phillips@amd.com/T/#m885ead1f280445357c91cce53c01217913bd017b
>
> Thanks,
>
> Kim