Date:   Wed, 17 Nov 2021 12:39:01 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     linuxarm@huawei.com, mauro.chehab@huawei.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev
Subject: Re: [PATCH 03/13] media: atomisp: sh_css_metrics: drop some unused
 code
Message-ID: <20211117093900.GK26989@kadam>
References: <cover.1637140900.git.mchehab+huawei@kernel.org>
 <e7c6d5349f4cdc002d6327c557e8c65a90e3447a.1637140900.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e7c6d5349f4cdc002d6327c557e8c65a90e3447a.1637140900.git.mchehab+huawei@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jVnbZPVRsTufzuUcwGvNTGXIwzpNyUo8yRNUVQAxBI/K3PEicHX+hUHisMWf?=
 =?us-ascii?Q?WsMUyb4iGoggLHhAxbWAya0A2wSiHTzoO3FrEYd/fnu+Mw3ORjh51JbgvvJL?=
 =?us-ascii?Q?vKJmlt5QEepU3XL2J+JPantZCs8v4SpATZl4zCljqjGQkA2dtUMaj29LDEDP?=
 =?us-ascii?Q?tjHI6TlsNSm6BTGbyq+Z0PoU2CQ8F8C9VFBdw56+QJwF/CLfS+NDUzkRhSZb?=
 =?us-ascii?Q?wIhdKuGm1jRqn0ioNc8FdZRrfBGfenNgz6K24PLowZL6W6+n+NTbXdvwh2c0?=
 =?us-ascii?Q?lQQov0teynL388imCrToMcYQ5Fn7PuxdvKlib5udyjoEUC7mMkOFNHu+Flsy?=
 =?us-ascii?Q?WlBvajJYLixJYw0nzSN+QJ1L+XpLHCaWA/mTsE//qoAt5AdrqvC94ckmvV5h?=
 =?us-ascii?Q?6GHNXcntFtCpU8/j8BQBt/vvUFxNueBQnJvbko4wGrK7kgCJKhFHjsaHYJbY?=
 =?us-ascii?Q?11weL1f8GAoEZYgubaWBZg28jw47OvTVZoiNCmH8ZtLNFnSIzioxt7PzGR5i?=
 =?us-ascii?Q?WJxsoFVxf+vmo10W2JP6XJ+RjTstIfsU4xe923R477VVKUb5QzpFPPP9Gqq2?=
 =?us-ascii?Q?HZE8JWwQp72FyyOohf1CyqT6atugJQW9QQWeLrSto7Bb8v6fO/JV60z+N3tO?=
 =?us-ascii?Q?FFwnfAqJsa7nlqE6WErTdsgIMMRjFzlA8IxPkX4QSJs7SwfiPvtESHkIwwYV?=
 =?us-ascii?Q?cDssB1RAjAGNvA7uyQyEHJhmhhh1k3mpPV4/+l/yOpxtsfuAEyzCJX1CdY1c?=
 =?us-ascii?Q?8WOoqelr+8mqie/Tl/tGM+uoaSLAiWZXDTTgS56vgHyJIaXN1LagMrN4inZr?=
 =?us-ascii?Q?Ma/B8E2YduFW+EZarjHMmYcUPjtlE1+i8hsV5dOnY9vJ4ATiZIfO2uUgo2Hy?=
 =?us-ascii?Q?EMLAFygDcYA+Ftl6tYfy4B705knrilwyQIQ4MSAMZwed3pOThbm9ARXD9Av+?=
 =?us-ascii?Q?9IbtsCw5o6vAagBfxQ9mTh1krWoqj2sg+bJW/qnUEgJ0ZbWMCYEkGJ4DVzBN?=
 =?us-ascii?Q?1URGp3OSprmQTkcUpHPpFHjVXbxN2itiFp3BiOK5mqzTj0E0n2kz97g7A5z0?=
 =?us-ascii?Q?e5WVP38ZOJ/OvUMgSrRm/b6Vw6djeLBKWmsmqvCaFFKoflGmfA0XKvbRedH+?=
 =?us-ascii?Q?7PB+j49vUvVtalz9Vh+WUrbu+DfcRUNkVPLaaEgvLwvndikiGgqthOjiJf3Q?=
 =?us-ascii?Q?HbpgSKgg84Lgc6jV47pxdnBnhMLyRTfOfwoHG0BnPJMaoJncTCyE5Hu52Yvs?=
 =?us-ascii?Q?REB4Ilc3Vdd2yfJxRK1GD6snSldEMET9oOZ1liffglmbadZ1j15mbXqsr03Q?=
 =?us-ascii?Q?55cm4KgUi5C5NC/SCIP5k+fRxqzXNel2So6WJgQkSNHO7rUchjh9HYVRAGy5?=
 =?us-ascii?Q?U9ugcCDkGsV3c8sUUMKwvB5S73W1rgUwgGig21u5OfS3/9wlB5WeTJ1DEhzS?=
 =?us-ascii?Q?4DNmXf6VVaNfECu/YrudIbHyeUQRq4DtickHsax/EmDQBxLJJJ266LIMPvLr?=
 =?us-ascii?Q?EL9oEYs94YN/wjWYYO2M4ScW9v4pYFSnVFjtolUVbQVoSpgJtHa46Qslu5nO?=
 =?us-ascii?Q?2OIsrNA+ABLnfTbMOuNxfA9DVW0kbz4td0A8oc5kklU2FIOawXZsMRCyZ0ZY?=
 =?us-ascii?Q?7MmKYZQ1FHxKYHBotQv3pe4ZhfJw5adnV39NDnip4PpozAjksxMOciLNj1fm?=
 =?us-ascii?Q?uG2CW5WcKpFDMJHs5YgK95x3n7U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7f56ac2-5800-4952-2c4a-08d9a9ae1db7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 09:39:14.4199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: loQSASrzH+toE1Hz6VMA1ozKO4F72aimN2JoexATMFlhj6IRSt50b/APQn9M1YPiIaRPZmLLaKLyHNDwl2DgLc8sEEzmwha1LGFheHmnGr0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5570
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10170 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111170047
X-Proofpoint-GUID: Ib67gz7_oVQjZp-8MET2CoCRuGY95RXb
X-Proofpoint-ORIG-GUID: Ib67gz7_oVQjZp-8MET2CoCRuGY95RXb
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 17, 2021 at 09:25:28AM +0000, Mauro Carvalho Chehab wrote:
>  .../media/atomisp/pci/sh_css_metrics.c        | 25 -------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_metrics.c b/drivers/staging/media/atomisp/pci/sh_css_metrics.c
> index 9744bbebe1bc..8ded6cdd1575 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_metrics.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_metrics.c
> @@ -123,40 +123,15 @@ sh_css_metrics_sample_pcs(void)
>  	unsigned int pc;
>  	unsigned int msink;
>  
> -#if SUSPEND
> -	unsigned int sc = 0;
> -	unsigned int stopped_sc = 0;
> -	unsigned int resume_sc = 0;
> -#endif
>  
> -#if MULTIPLE_PCS
> -	int i;
> -	unsigned int pc_tab[NOF_PCS];
> -
> -	for (i = 0; i < NOF_PCS; i++)
> -		pc_tab[i] = 0;
> -#endif
>  
>  	if (!pc_histogram_enabled)
>  		return;

There are three blank lines in a row now.  Checkpatch is not smart
enough to spot this until you re-run it with the -f file mode after
applying the patch.

This is an easy mistake to make and you did it a couple times in
yesterday's patchset as well.  No big deal.  Could you re-run
checkpatch.pl at the end and clean it up afterwards?

regards,
dan carpenter