MIME-Version: 1.0
References: <1637133726-6581-1-git-send-email-u0084500@gmail.com>
In-Reply-To: <1637133726-6581-1-git-send-email-u0084500@gmail.com>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Wed, 17 Nov 2021 18:52:52 +0800
Message-ID: <CAE+NS37eLbnTZtv5pO59XWrWVKEJEA+J8DE=H1NwZr+u71WwfQ@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in
 mt6360 example
To:     cy_huang <u0084500@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Gene Chen <gene_chen@richtek.com>, wilma.wu@mediatek.com,
        benjamin.chao@mediatek.com, ChiYuan Huang <cy_huang@richtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

cy_huang <u0084500@gmail.com> =E6=96=BC 2021=E5=B9=B411=E6=9C=8817=E6=97=A5=
 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:22=E5=AF=AB=E9=81=93=EF=BC=9A
>
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
>
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114=
.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1
>
> Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+s=
D3ukce_xQF+gA@mail.gmail.com/
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Hi, Gene:
>
> I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
> But you may forget to remove it from the binding example.
>
> Please help to review this change.
> ---
>  Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Do=
cumentation/devicetree/bindings/leds/leds-mt6360.yaml
> index 2353155..b2fe6eb 100644
> --- a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> @@ -133,7 +133,7 @@ examples:
>       };
>       led@3 {
>         reg =3D <3>;
> -       function =3D LED_FUNCTION_MOONLIGHT;
> +       function =3D LED_FUNCTION_INDICATOR;
>         color =3D <LED_COLOR_ID_WHITE>;
>         led-max-microamp =3D <150000>;
>       };
> --
> 2.7.4
>

Reviewed-by: Gene Chen <gene_chen@richtek.com>
Thanks