Date:   Wed, 17 Nov 2021 08:01:28 -0300
From:   Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To:     Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc:     linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-staging@lists.linux.dev,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Fabio Estevam <festevam@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Heiko Stuebner <heiko@sntech.de>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>, kernel@collabora.com
Subject: Re: [PATCH v8 11/12] media: hantro: Staticize a struct in
 postprocessor code
Message-ID: <YZThCK6+/jA+P/v8@eze-laptop>
References: <20211116143842.75896-1-andrzej.p@collabora.com>
 <20211116143842.75896-12-andrzej.p@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211116143842.75896-12-andrzej.p@collabora.com>
Precedence: bulk

On Tue, Nov 16, 2021 at 03:38:41PM +0100, Andrzej Pietrasiewicz wrote:
> The struct is not used outside this file, so it can be static.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

> ---
>  drivers/staging/media/hantro/hantro_postproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/hantro/hantro_postproc.c b/drivers/staging/media/hantro/hantro_postproc.c
> index 4549aec08feb..89de43021779 100644
> --- a/drivers/staging/media/hantro/hantro_postproc.c
> +++ b/drivers/staging/media/hantro/hantro_postproc.c
> @@ -33,7 +33,7 @@
>  #define VPU_PP_OUT_RGB			0x0
>  #define VPU_PP_OUT_YUYV			0x3
>  
> -const struct hantro_postproc_regs hantro_g1_postproc_regs = {
> +static const struct hantro_postproc_regs hantro_g1_postproc_regs = {
>  	.pipeline_en = {G1_REG_PP_INTERRUPT, 1, 0x1},
>  	.max_burst = {G1_REG_PP_DEV_CONFIG, 0, 0x1f},
>  	.clk_gate = {G1_REG_PP_DEV_CONFIG, 1, 0x1},
> -- 
> 2.25.1
>