Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04C3C433FE for ; Wed, 17 Nov 2021 11:25:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A836661B42 for ; Wed, 17 Nov 2021 11:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236796AbhKQL2m (ORCPT ); Wed, 17 Nov 2021 06:28:42 -0500 Received: from gandalf.ozlabs.org ([150.107.74.76]:57869 "EHLO gandalf.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236771AbhKQL2j (ORCPT ); Wed, 17 Nov 2021 06:28:39 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4HvLFv1hzMz4xdV; Wed, 17 Nov 2021 22:25:39 +1100 (AEDT) From: Michael Ellerman To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Finn Thain , Stan Johnson , "Christopher M . Riedl" In-Reply-To: <99ef38d61c0eb3f79c68942deb0c35995a93a777.1636966353.git.christophe.leroy@csgroup.eu> References: <99ef38d61c0eb3f79c68942deb0c35995a93a777.1636966353.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH] powerpc/signal32: Fix sigset_t copy Message-Id: <163714821584.1508509.9112860111598863862.b4-ty@ellerman.id.au> Date: Wed, 17 Nov 2021 22:23:35 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Nov 2021 09:52:55 +0100, Christophe Leroy wrote: > The conversion from __copy_from_user() to __get_user() by > commit d3ccc9781560 ("powerpc/signal: Use __get_user() to copy > sigset_t") introduced a regression in __get_user_sigset() for > powerpc/32. The bug was subsequently moved into > unsafe_get_user_sigset(). > > The bug is due to the copied 64 bit value being truncated to > 32 bits while being assigned to dst->sig[0] > > [...] Applied to powerpc/fixes. [1/1] powerpc/signal32: Fix sigset_t copy https://git.kernel.org/powerpc/c/5499802b2284331788a440585869590f1bd63f7f cheers