From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Joe Perches <joe@perches.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] get_maintainer: look for configuration files in
 ./scripts
Date:   Wed, 17 Nov 2021 13:07:58 +0100
In-Reply-To: <6358495179b8abceafb651e58e933b8cf3a8ff1f.camel@perches.com>
        (Joe Perches's message of "Tue, 16 Nov 2021 15:10:21 -0800")
Message-ID: <dleftjczmzgf35.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <6358495179b8abceafb651e58e933b8cf3a8ff1f.camel@perches.com>
        <CGME20211117120811eucas1p1cdc0aa3ab93d11cebf85592d4e98f0c7@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-11-16 wto 15:10>, when Joe Perches wrote:
> On Tue, 2021-11-16 at 22:34 +0100, =C5=81ukasz Stelmach wrote:
>> Change ".scripts" to "./scripts" as described in commit bcde44ed7d2a
>> ("scripts/get_maintainer.pl: use .get_maintainer.conf from . then $HOME
>> then scripts").
>
> The intent there was to use the <kernel_tree>/scripts directory

I am afraid bcde44ed7d2a[1] removed references to ${lk_path} and made
git_maintainer.pl look for the files in the directory the script is
invoked from.

> Adding . to that would change that.

Andrew points out[2] that some we might need to include .scripts
too. Where do we expect the config files to be (do comment)?

.                   - current directory (?)
${lk_path}/         - the top directory of source tree
${HOME}/            - per-user
${lk_path}/scripts  - how is this dfferent from ${lk_path}?
${lk_path}/.scripts - Andrew says someone might have started using it

I'd also add in this commit or another
${XDG_CONFIG_HOME}/get_maintainers. However, I think files in this
directory should be named conf and ignore instead of
.get_maintainer.conf and get_maintainer.ignore (respectively).


[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm=
it/?id=3Dbcde44ed7d2a
[2] https://lore.kernel.org/lkml/20211116135627.321aa8ef46ee389cf66692df@li=
nux-foundation.org/
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmGU8J4ACgkQsK4enJil
gBCZmggAhLC3PyMdHpaR6kj2II9NuWyyUChrj5l5xgo7vX9kyEOgl7fTS13KHfEf
hymgTWo+zhxE34ilpCcNM++mpkcyo2ICx1e/gVwh4erRGQPzt/Qg0JY1c1w6c6TT
Wzf55uSBByiVFEgmamHzy+mURVh6yJ9NqBI5zDokiHdzts3/IwDcP4+uQhnNwcvX
lmlQQRfIpc2B8LxETCbI6ngpO9Qa0MRtL6H9OtURwBumUSWWtUHBhGLzFSdthpaF
M9KGdwgN50QOCvAmgXHaijrki1/yjC7rNjXyG7iELvAaa7Nz6MqbAyeM3ju0eMjt
pJCwG2ht6Sjl0mIpnpaLeanVOe0vMg==
=PmqH
-----END PGP SIGNATURE-----
--=-=-=--