Date:   Wed, 17 Nov 2021 11:21:06 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Madhavan Srinivasan <maddy@linux.ibm.com>
Cc:     Thomas Richter <tmricht@linux.ibm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        sumanthk@linux.ibm.com, jolsa@redhat.com, svens@linux.ibm.com,
        gor@linux.ibm.com, hca@linux.ibm.com
Subject: Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next
Message-ID: <YZUP0rlCX8PP93l2@kernel.org>
References: <20211103155215.2941895-1-tmricht@linux.ibm.com>
 <beeecf6d-3cd9-2072-ee7c-13712a77807d@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <beeecf6d-3cd9-2072-ee7c-13712a77807d@linux.ibm.com>
Precedence: bulk

Em Wed, Nov 17, 2021 at 02:35:29PM +0530, Madhavan Srinivasan escreveu:
> 
> On 11/3/21 21:22, Thomas Richter wrote:
> > Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> > broke the test case 27 (Sample parsing) on s390 on linux-next tree:
> > 
> >    # ./perf test -Fv 27
> >    27: Sample parsing
> >    --- start ---
> >    parsing failed for sample_type 0x800
> >    ---- end ----
> >    Sample parsing: FAILED!
> >    #
> > 
> > The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> > in above commit.  Correct this define and the test case runs fine.
> > 
> > Output After:
> >    # ./perf test -Fv 27
> >    27: Sample parsing                                                  :
> >    --- start ---
> >    ---- end ----
> >    Sample parsing: Ok
> >    #
> 
> 
> Hi Thomas,
> Thanks for the fix. Not sure, I guess I messed up my big endian setup or
> test run I had before sending
> the patch. My bad. It fails for me too, but with your patch the issue fixed.
> 
> Acked-and-Tested-by: Madhavan Srinivasan <maddy@linux.ibm.com>

Thanks, applied.

- Arnaldo