Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211116014726.1452-1-vulab@iscas.ac.cn>
References: <20211116014726.1452-1-vulab@iscas.ac.cn>
Subject: Re: [PATCH] media: mtk-jpeg: Remove unnecessary print function dev_err()
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-kernel@vger.kernel.org
To:     Xu Wang <vulab@iscas.ac.cn>, bin.liu@mediatek.com,
        matthias.bgg@gmail.com, mchehab@kernel.org, rick.chang@mediatek.com
Date:   Wed, 17 Nov 2021 14:40:49 +0000
Message-ID: <163716004951.420308.9398665375877390415@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Xu Wang (2021-11-16 01:47:26)
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.

This one was also reporting errors in the case of -EPROBE_DEFER, which
will now go away, so this looks like a valid change to me.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/me=
dia/platform/mtk-jpeg/mtk_jpeg_core.c
> index af994b9913a6..f332beb06d51 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1361,10 +1361,8 @@ static int mtk_jpeg_probe(struct platform_device *=
pdev)
>         }
> =20
>         jpeg_irq =3D platform_get_irq(pdev, 0);
> -       if (jpeg_irq < 0) {
> -               dev_err(&pdev->dev, "Failed to get jpeg_irq %d.\n", jpeg_=
irq);
> +       if (jpeg_irq < 0)
>                 return jpeg_irq;
> -       }
> =20
>         ret =3D devm_request_irq(&pdev->dev, jpeg_irq,
>                                jpeg->variant->irq_handler, 0, pdev->name,=
 jpeg);
> --=20
> 2.25.1
>