Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A735C433F5 for ; Wed, 17 Nov 2021 15:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AB6161A56 for ; Wed, 17 Nov 2021 15:31:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238209AbhKQPez (ORCPT ); Wed, 17 Nov 2021 10:34:55 -0500 Received: from marcansoft.com ([212.63.210.85]:37212 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237974AbhKQPey (ORCPT ); Wed, 17 Nov 2021 10:34:54 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id AB13F41F28; Wed, 17 Nov 2021 15:31:52 +0000 (UTC) Subject: Re: [PATCH] drm/format-helper: Fix dst computation in drm_fb_xrgb8888_to_rgb888_dstclip() To: Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20211117142206.197575-1-marcan@marcan.st> <926ff1f6-2255-4e94-3a24-4fc78260f27d@suse.de> From: Hector Martin Message-ID: Date: Thu, 18 Nov 2021 00:31:49 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <926ff1f6-2255-4e94-3a24-4fc78260f27d@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/11/2021 23.56, Thomas Zimmermann wrote: > Hi > > Am 17.11.21 um 15:22 schrieb Hector Martin: >> The dst pointer was being advanced by the clip width, not the full line >> stride, resulting in corruption. The clip offset was also calculated >> incorrectly. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Hector Martin > > Thanks for your patch, but you're probably on the wrong branch. We > rewrote this code recently and fixed the issue in drm-misc-next. [1][2] Oops. I was on linux-next as of Nov 1. Looks like I missed it by a week! Sounds like I'm going to have to rebase/rewrite the other series I just sent too... -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub