Message-ID: <ed47fcdb-f841-65e6-be70-a12303ac153e@oracle.com>
Date:   Wed, 17 Nov 2021 11:05:57 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: [PATCH v2] xen: don't continue xenstore initialization in case of
 errors
Content-Language: en-US
To:     Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        Stefano Stabellini <stefano.stabellini@xilinx.com>,
        Stable@vger.kernel.org, jbeulich@suse.com
References: <20211115222719.2558207-1-sstabellini@kernel.org>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211115222719.2558207-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDhmVmRJcXNFR0pmeTJaZ2VrdDE4cXdrdUJpMlg2VHNwMENmZWVodHl1Tloy?=
 =?utf-8?B?Mmc5S3JLMFI3QTQvQUR6Qzg1VS9QUXloU2NKWXRPWnMwT0Znc3BucEFxU2Jm?=
 =?utf-8?B?aUp6bUtzUjJ6RmdpZC9HZ2NkR0J2d28xRzkzN3BWZzlTb09iMk80R3MwSHBr?=
 =?utf-8?B?amJzNTNSTjdyV3J1Wktzb0J4cWpZY2JUYlI0Mkw5di8weW04aHJ2KzdSV0E3?=
 =?utf-8?B?aERnaWJHdjZvNno3cUNldGxrUFZGK3FvVnBQSXhPN3Y2QnZFOHdZWFFZWVpO?=
 =?utf-8?B?TitlaGNaSDFvaGVjRE45U25KamI1ZzVFaVJqNzljL2I4UnVGdExNODRlRGth?=
 =?utf-8?B?TlFPSXRFakljU1hsQVlPcldqUFpPenc1UHk5UDhvYkY5VGFPZXE1TWxQUzd6?=
 =?utf-8?B?eGpHcUloK0xoUnBOSHpDQWZSeGdmR250TGJJaVo4bVE0eEJEM21MWGNGOTVO?=
 =?utf-8?B?QVQyS0ZEbTRtSFRoWXNjdVVpQjBPeklGT0FVNVpHZEpXMHlvVTdjbWhNeldy?=
 =?utf-8?B?ZEdIS3U2czlvVzlPSEFjWE1iZ2JsbjBKTmw5RC9LU01QK2hYWlZkSzRSVmFt?=
 =?utf-8?B?YmNQd3hXNnpvaUU3UWZBNDFNWVlpbTNxUWI0MXdMSFhteTFUd2VIRy9Qd2pt?=
 =?utf-8?B?VGh5Vit3NWE1Mkl1bUh1aXVXTDVyck1SME9DT0ZGYURuaVZES3YyTnlPZit3?=
 =?utf-8?B?VTQyWG5ER1ZWU0tFUDN2WnNDWFlycU5VOFo2Z0Rld1dTVktTWEZiaHBDYnhp?=
 =?utf-8?B?YytMVDdTNjdvNnNjckhPcnpXdHU4N0RzLzRUSmhFMFNQNEt6MytDVjlzLzJ0?=
 =?utf-8?B?ZXVpUzlOdm1CVmVhSThWaGVXejVIY2dmZFhlZ090bEJ4U2FMNE9UalJ6cjlN?=
 =?utf-8?B?NGkycStHMXgzaDlLcHpXNmEzUHJwRTcrYy9vaGJBM3JRa0UrTWtWU0d6ZzVU?=
 =?utf-8?B?VHRLQkE0T055endIYlZwYUJkNFBGSWNtMy9ub1RxdGJPTmJiWjJTUXV1Tm1D?=
 =?utf-8?B?b1FUVjlVUXR2NSt0SDErOGlnWjJpa3JaM25GWGxobDBxVmhudnJMQ1ZWM0Ew?=
 =?utf-8?B?SElCRURZN28xZXIwa0cwdEtaRHhoMzZRRnRiWlJmNytveEdpWmU2Qm52VWdH?=
 =?utf-8?B?VDhQWVZ6MmpRYzdFVFVZTVVHNWtKS2JPNUFJMy94VFI1REQ1VkxOR1dMakQv?=
 =?utf-8?B?Z0J6NVVzTU5PTWp4b0xQUUdUeXgyREVqemc5dFJCaUVqRFR2dFFqaDVaanlI?=
 =?utf-8?B?VUdFenppVmNmQnNqaEoyKzMyQ0NlbDFKSXIyWEExK2pPWVhQS3VwU2pvaWlY?=
 =?utf-8?B?d1lGTHlmdU5rNDYwT1BSTmMrMVN2eXhJR3dWRG9BQ0wwZnY0dXd3ZE13NWdQ?=
 =?utf-8?B?ZVZxTmZKbldLQVdRRGM3SEJGV2NRV3BSME1SaElnM1dQemczQlIrQ2R0anBk?=
 =?utf-8?B?cExvc1Nxd0Yvd0pZOXRkblc3Y2pqNGFwZi9sMVlxVEZOY1N5NnF6T2N5YXRo?=
 =?utf-8?B?MHpyVWp6L3VUMmtUcHl6RzZXMHZJdkd2MFVDV0xKMnVSYkRud3lFVWVBODBY?=
 =?utf-8?B?L2lHbDNLNUh6R25UWTYva2JmcTNYejF2Mm1FSmFnZjRnbFpwd1JpdUN3T1h3?=
 =?utf-8?B?MjJJNSsxTlhuTEljY1hlTnFGdGxZekJpUHVqb1U1ZU5SUTRtVUNWMnlOSFVN?=
 =?utf-8?B?QTJYNUI0RDZmUzNrR1RzQTBtbE9xaFZ4eHFsZ3FQT2tudElScm1yN2p0bnV3?=
 =?utf-8?B?WFJmK3B5L21ROHI1bCtLUXJjc2k1UnZnMmZMaEpKak1iZVloc3BjcnZ6Q2Nl?=
 =?utf-8?B?R1R3T1g3ZXdnZHdsdGJiR1J1dERDcm41S2c4VmRzUjZJTkRUOEFGZTNySmMw?=
 =?utf-8?B?UlpGeHU0SjZ0Ni9PVkI2NHVCKyswSHlJTXZFZUp5aElIQ2ZuNGhCU0gwcEcw?=
 =?utf-8?B?Vk9UOU8zMVVTMXRJR2UrZlJrK1ZyYURpWmJQNE5YaG9aOHZ1d0RmNDduK29k?=
 =?utf-8?B?dFRUTzV1QjhBdGlUc2tKTWk4R0RYWERmK0JTalQzbVlQYkp1UW8reFdtTjZ6?=
 =?utf-8?B?Zm1VWlRma3hiT2wxK1d0d1ZjNC9Cd3VmUkpqREsvRXpBYTBESU1wajNodWRL?=
 =?utf-8?B?eERqa01XUVJCN1ZPeEJSZVhaMTgwSGc0bS9UOTI2ZmRUUlJ3Z0tqTy8vVEli?=
 =?utf-8?B?YUVYdmhpVGpHZFcxeENUaXMrT0tBdWxNbXNQKzZxR3R4ZnVWMWlpM2dVZ3Ft?=
 =?utf-8?B?aHVJQ2h5NTR3enBBNHNaR2NCNzR3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3d243b-e3a1-4f12-7233-08d9a9e42756
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 16:06:02.9629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lDtLUKLAVzN2EaidJOcluK2BtDCpVWSmjrtVCvBdPqIFCNF/HMVas2+dIRic6wYW042A/N2Uy6xI9RIsxyKr+6F9uuJStP2GNc+zAHwhXUU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5042
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10171 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111170075
X-Proofpoint-ORIG-GUID: tSwjEGZwZIg_kvrro00YhUG1delN9QP-
X-Proofpoint-GUID: tSwjEGZwZIg_kvrro00YhUG1delN9QP-
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/15/21 5:27 PM, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter),
> we goto out_error but we forget to reset xen_store_domain_type to
> XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls
> will still try to initialize xenstore resulting into a crash at boot.
>
> [    2.479830] Call trace:
> [    2.482314]  xb_init_comms+0x18/0x150
> [    2.486354]  xs_init+0x34/0x138
> [    2.489786]  xenbus_probe+0x4c/0x70
> [    2.498432]  xenbus_probe_initcall+0x2c/0x7c
> [    2.503944]  do_one_initcall+0x54/0x1b8
> [    2.507358]  kernel_init_freeable+0x1ac/0x210
> [    2.511617]  kernel_init+0x28/0x130
> [    2.516112]  ret_from_fork+0x10/0x20
>
> Cc: <Stable@vger.kernel.org>
> Cc: jbeulich@suse.com
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>


Applied to for-linus-5.16c


-boris