Message-ID: <c029ea68-e48f-dc60-a8a2-01bb34f692d4@intel.com>
Date:   Wed, 17 Nov 2021 08:46:16 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: [PATCH] selftests/resctrl: Skip MBM&CMT tests when Intel Sub-NUMA
Content-Language: en-US
To:     "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
References: <20211110082734.3184985-1-tan.shaopeng@jp.fujitsu.com>
 <c23356c7-3af7-0aba-18b6-2e53ce18a164@intel.com>
 <TYAPR01MB63300DC31AFB0013808FC7948B989@TYAPR01MB6330.jpnprd01.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <TYAPR01MB63300DC31AFB0013808FC7948B989@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dE13dE9PQ3ZWZ2FrakowQkowNm5WNkVrT1d4ckNSMEFtMkVxbkZTY0lTUzRG?=
 =?utf-8?B?eTlydTNDN1R0RHc0ZW1DM0tvaUlGaDk1cjkrUXJRckFmZ040WWZuVVY4V1I2?=
 =?utf-8?B?dlJUY1JwMVY1QURERzlzK1FGYlk5cDVISXhwaUZqeFF0TEdnT1hobXAvQzhF?=
 =?utf-8?B?eUtKdDliaEFQT3ZJSHcyYU91dHRZdXoyd3hsOHRIa3JCbmtoY3hOT3BuSHBn?=
 =?utf-8?B?RGR2UEpFaHZJUHJrelJ2VGJPOWhZTnR1SFNCcnh6ZmRQNnJ6alB5L3EvSXBV?=
 =?utf-8?B?cGh3VDFyTmVDQnBEaG1hWWxYOWh6SWxuVGZOYVRJVkNSTk1PWFpzdENSblpX?=
 =?utf-8?B?ME5kcEdvOHJ4MERpWVcyT3JyK1FKTzNNTlpLSW5vQUhJV2xSZjJaU0FHQzVo?=
 =?utf-8?B?UFRtWDl5TGI3THdIK3Z2UlZlTlpzOVJRR3g3cnNjTkxvUjJOSmVJL2NqcVAx?=
 =?utf-8?B?STUrQWlEbGR4UURiU3dRMzBKNWFyUFcySTF6SXREdG42TGtaZkNkQ1ZTZENt?=
 =?utf-8?B?TERVWkdaMmNZSmRMVTFxYzAvVmJBdDZvS1Q3UC9RL1JQQ3M3bU9uVk13Wi9a?=
 =?utf-8?B?Y2dsUk9yNmh0V0FLWERxSUIvdVB4c1JkTjY2cXRRRng4YnB3NkhZU0xQdDBm?=
 =?utf-8?B?TEtOSmo1aGtBY0RxQWQwZG9jSFFiY29uMXBJYUNhc3pmc3VBdlBjWDNZYjlU?=
 =?utf-8?B?cFBGSXlQYjFjZm5nbnR6OERjUVUwM2o3OTN0eWNuUm9IdkkxR1V2UFd6ZUg2?=
 =?utf-8?B?dklZT0orK2VsQjd5RmV0TEFnaXZqQmVjdzJ6K3RRYUIzQ1djSmlRYms0ODdx?=
 =?utf-8?B?VGJwUTFjZXJXVTA4RnFBcEs1V0pMVkdTT0dvRmIvbVNVbWpWenlsaVVkc0Rh?=
 =?utf-8?B?ZVZacEZOMDIzN1pqQUdlQjAxZklUbEgzM2hLS3dXN1pQRGZkejFMSldHNFl6?=
 =?utf-8?B?KzFZZU1tQ0JUREtXYnhzWHZSUFZMd0t6SGY4d05ZUG1pZ2ovUlRQNlRZVEFs?=
 =?utf-8?B?N2U1MUVXWUNTMUpIOWMxTlByT05yNUY1SHZaV0hjUGgrUDdYUnQzSkJPOVor?=
 =?utf-8?B?aGdXSVFLTXk1akx1WG9XcWxUN01KQmgzZjVWM3UwckVsS1FJcjdPSlB6ZnpD?=
 =?utf-8?B?Y1lSQmZGV1ZJakxMMEcrbDY5MENEMi9SL2NZRVdJZjhsVHJFRkNldDRmSjhh?=
 =?utf-8?B?V0FlcU00anR1cnhmek1aeGl6disxZk5SYlRRdnhiM1hWY29qNjIxaDYyd3BT?=
 =?utf-8?B?TWpoSThRUEFMVWtDTG5yS1dlaTRGUUFQT08xdys1WVBDSW9XOUQwOU5QVUFl?=
 =?utf-8?B?eHVlbnl1eDNGTm93T2FEdHhQTGRKRllsKzk3Zk1neFRIdHE0MmxGaG4yT3Fz?=
 =?utf-8?B?QmxLanZKOGh4Y2FScWlvc3lheGIvMmRoTCtaaU9VNUxjY2RyYlN5ckZqOGJE?=
 =?utf-8?B?K0IyRHBZN3NEakgyNy9IRjhEY1cvMFJyWmhrcW1FWVBNaEt4cG5UeHpvN1BS?=
 =?utf-8?B?a1V2RVZScmE0MFovbm9RenN1dFdSaG1BL1Z4bUJrbWVRSHZKaVV2RU9McXJ2?=
 =?utf-8?B?QnJURVZaMU9VY0I0YkRUcTBpUnByT0NBZU0zUVlhTWVVdnNWUDJHSFNpMFBZ?=
 =?utf-8?B?d3l5bFJsaG9Uc2duRFFrTTE0OGgrdjlNekt4U1dab09oN1FNeSs0QUJGd3M4?=
 =?utf-8?B?Um1ZQkxwVGc2bi9GMXQvSkdPUzZQd1hzRFAvS0NhTEdsck1sVnYrYjZSanRZ?=
 =?utf-8?B?djRPVWJJaUFZRjBvVVBUT3p2YWpSY1lEbjZjVk5aNXBpZG1sQkVTL2Z2RkNx?=
 =?utf-8?B?Z3IrRlZtSlphZTQ3STB2STRoSmRvTzVYZVVyUWM3TUhTZ2gremp5K3krWE9M?=
 =?utf-8?B?NjJYRXdjN2pnWThnTWJBOEZwYnZOWk0rYWZMdDFHbkZJZkNTdFBjUGJHcXJh?=
 =?utf-8?B?bHF1L2FDL2hwMER0MjFLa2xITjFhcmlCUmtqZlZjRGk4YXJnQVRIRFpyMXRs?=
 =?utf-8?B?bEFhRVVSbE5QcUk1KzN3aGl4eE5TV3dybS9vTkJqdHgzOVdpNWx0RlRnU0R5?=
 =?utf-8?B?QWgwbmhsSUJoRWtYaW5LbThGNjM2amZacVNLa21naXFhTkxZNHFuNkg0YmJl?=
 =?utf-8?B?VEs3RldkazdvWWpSdGlNNWlBUVMxVTZ5UHM1aVM2RnM0cE8xMENQMkY5dVlm?=
 =?utf-8?B?U3I2N1p5RmtHZVhWaHU5NWQwNGRsK0FiMVJQUnNUT3F5Z2RyNU1vU0YxYlBl?=
 =?utf-8?B?amUxbC9vZTgrOXFNdUkrUVl6S1BBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c6ed5a5-abdf-454e-ca41-08d9a9e9c88c
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 16:46:21.3281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EeYFmbbNZCN9pTpSfjWNNE7Htj+bdV20j8uwBDDywtVr4Ii7mfKTDYFnTpz3oL61aYp2mOjZ0hY1c26ZYcT8dKhN4fhZ4K0zRN7Z0sXrXbA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3732
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 11/14/2021 11:11 PM, tan.shaopeng@fujitsu.com wrote:
> Hi Reinette,
> 
>> On 11/10/2021 12:27 AM, Shaopeng Tan wrote:
>>> From: "Tan, Shaopeng" <tan.shaopeng@jp.fujitsu.com>
>>>
>>> When the Intel Sub-NUMA Clustering(SNC) feature is enabled,
>>> the CMT and MBM counters may not be accurate.
>>> In this case, skip MBM&CMT tests.
>>>
>>> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
>>> ---
>>> Hello,
>>>
>>> According to the Intel RDT reference Manual,
>>> when the sub-numa clustering feature is enabled, the CMT and MBM
>> counters may not be accurate.
>>> When running CMT tests and MBM tests on Intel processor, the result is "not
>> ok".
>>> So, fix it to skip the CMT & MBM test When the Intel Sub-NUMA
>> Clustering(SNC) feature is enabled.
>>>
>>
>> It is not clear to me which exact document you refer to but I did find a
>> RDT reference manual at the link below that describes the problem you
>> mention:
>> https://www.intel.com/content/dam/develop/external/us/en/documents/18
>> 0115-intel-rdtcascadelake-serverreferencemanual-806717.pdf
> 
> Yes, I referred this manual.
> 
>> What is not mentioned in your description is that this is a hardware
>> errata so the test is expected to fail on these systems and I find that
>> disabling the test for all systems based on this hardware errata is too
>> drastic.
> 
> Understood. It is not reasonable to disable the test for all systems
> based on this hardware errata.
> When I run restrl_test on Intel(R) Xeon(R) Gold 6254 CPU,
> the result of CMT & MBM is "not ok", and I took some time to debug it.
> In order to other people can do the test smoothly, I'd like to update the
> patch to disable the test only on 2nd Generation Intel Xeon scalable processors.

I've been thinking about this some more and I do not think that the test 
should be disabled. There is a clear incompatibility between SNC and RDT 
on these systems and I do not think the test should hide that, indeed it 
is helpful to highlight that there is an issue. Even so, spending time 
to debug a known issue is not a good use of time. Instead of skipping 
the test on these systems could the test perhaps be improved to provide 
more information on failure to help user decide if they really need SNC 
enabled? The test would show that RDT cannot be used on their system 
with the SNC configuration, hiding that information by skipping the test 
may create false idea that RDT is working with that configuration.

Reinette