Date:   Wed, 17 Nov 2021 17:29:08 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc:     alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com,
        lgirdwood@gmail.com, daniel.baluta@nxp.com,
        daniel.baluta@gmail.com, AjitKumar.Pandey@amd.com,
        Balakishore.pati@amd.com, vsreddy@amd.com,
        Julian.Schroeder@amd.com, vishnuvardhanrao.ravulapati@amd.com,
        linux-kernel@vger.kernel.org, yc.hung@mediatek.com,
        linux-mediatek@lists.infradead.org,
        =?iso-8859-1?Q?P=E9ter?= Ujfalusi 
        <peter.ujfalusi@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Subject: Re: [PATCH 16/21] ASoC: SOF: topology: Add support for Mediatek AFE
 DAI
Message-ID: <YZU75B2JHbYHy40l@sirena.org.uk>
References: <20211117093734.17407-1-daniel.baluta@oss.nxp.com>
 <20211117093734.17407-17-daniel.baluta@oss.nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y1aGE2SznRaFViUz"
Content-Disposition: inline
In-Reply-To: <20211117093734.17407-17-daniel.baluta@oss.nxp.com>
Precedence: bulk


--y1aGE2SznRaFViUz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 17, 2021 at 11:37:29AM +0200, Daniel Baluta wrote:
> From: YC Hung <yc.hung@mediatek.com>
>=20
> Add new sof dai and config to pass topology file configuration
> to SOF firmware running on Mediatek platform DSP core.
> Add mediatek audio front end(AFE) to the list of supported sof_dais

This breaks an x86 allmodconfig build:

/mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c: In function 'mt8195_run=
':
/mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c:207:2: error: implicit d=
eclaration of function 'sof_hifixdsp_boot_sequence' [-Werror=3Dimplicit-fun=
ction-declaration]
  207 |  sof_hifixdsp_boot_sequence(sdev, adsp_bootup_addr);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
At top level:
/mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c:201:12: error: 'mt8195_r=
un' defined but not used [-Werror=3Dunused-function]
  201 | static int mt8195_run(struct snd_sof_dev *sdev)
      |            ^~~~~~~~~~
cc1: all warnings being treated as errors

_boot_sequence is added in "ASoC: SOF: mediatek: Add fw loader and
mt8195 dsp ops to load firmware" which is later in the series.

mt8195_run should be either global, a static inline or not declared in
the header at all.

--y1aGE2SznRaFViUz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGVO+MACgkQJNaLcl1U
h9BHUAf/WPdQ1sU34pc7wXKT7HjpQzqXz6Y92JQZagFk6v6n4c5zaV8lGeMp4RJe
b7qYWE1l7b+95S89NCV2cZOTqRX/e0aikOjZp4COv6NUSx9wwq6niGVbf7Vp7514
eRbtxcUNrzrjW6ccMgjuV9J5X+QMXY6+hShIqxVFFDWuzQl0TzXFpXaZ1mb7C1gC
KQIkWxluoO20C4TSQi/TvoxSGnxIfq4dvrb6i1oVMFnMOBvbQrqPRkVs1+r+cv8K
s43s9ZjcIQkDOzVX76tMmLSb64yEP+7FJzlwIhaIaPOoMmebYpzzf8JNHE4rjti1
necJgXEnDl0sH2hhC7ZS5gv1m6qkGQ==
=WcZw
-----END PGP SIGNATURE-----

--y1aGE2SznRaFViUz--