Subject: Re: [PATCH 16/21] ASoC: SOF: topology: Add support for Mediatek AFE
 DAI
To:     Mark Brown <broonie@kernel.org>,
        Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc:     alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com,
        lgirdwood@gmail.com, daniel.baluta@gmail.com,
        AjitKumar.Pandey@amd.com, Balakishore.pati@amd.com,
        vsreddy@amd.com, Julian.Schroeder@amd.com,
        vishnuvardhanrao.ravulapati@amd.com, linux-kernel@vger.kernel.org,
        yc.hung@mediatek.com, linux-mediatek@lists.infradead.org,
        =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
References: <20211117093734.17407-1-daniel.baluta@oss.nxp.com>
 <20211117093734.17407-17-daniel.baluta@oss.nxp.com>
 <YZU75B2JHbYHy40l@sirena.org.uk>
From:   Daniel Baluta <daniel.baluta@nxp.com>
Message-ID: <e918b4c4-dc85-dcf5-2781-5edfcd1bf1a5@nxp.com>
Date:   Wed, 17 Nov 2021 19:32:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <YZU75B2JHbYHy40l@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?/COlH7rRjMXjxDXndk+td7TN2Bo/pZncI0oQtrg37S6Zs2s3ehPCNiWF?=
 =?Windows-1252?Q?uawNuD7KkpWEJTu7KYi1x7ab8HOFD/04NGbGjWXYfA3cV1oMHQKL/8fm?=
 =?Windows-1252?Q?SeyEowT/fe3CKmRtda1stpnmPLajFWb5ZSkDia9WtieKgWtVXC1wp4vW?=
 =?Windows-1252?Q?tw7eLlFNGiqmcdOjlBpLnq0rxDlpoHrCYc66OMjcy+sFsmUzHFQeIadE?=
 =?Windows-1252?Q?bLcE1LaGKwxF9xK/S2ks7jcqgFmsFPWYSGaJUdixhS7uyUpbpwp4IGYJ?=
 =?Windows-1252?Q?arkOeqmib3bajmEZFlKDCs+YcSS4eteYkyjO3XKUQ9rU+rZtiaMaZluM?=
 =?Windows-1252?Q?R/911aA17CGcxOzVlmQCkLd3InqarsNalWVuCyeEY8Judfzs+H+vxwuV?=
 =?Windows-1252?Q?D3G9xe1QOZ/tWAtfMjLpy0GgvNLQ9D4e/W/BkPeXxg/XkBe5dvk5GtsX?=
 =?Windows-1252?Q?anXU+DyllZZg7l0Cx51WMSAxiuKWTghGgd+DlKB6XQ1i0zd61s7tzNdR?=
 =?Windows-1252?Q?uwcKUh/5MKu/iXdz6wBfZQua4vseceocxbefD2tOt3CqaKkJr9XETK91?=
 =?Windows-1252?Q?HNxI4WhWmM6XAWkfYp10VlOFYSEV17D4XxIXI5j+JELemSNUKrpH92FX?=
 =?Windows-1252?Q?LDRze2Whzai4BmZ9mtdUT8fHJMzKnfkxy8+dc7f/rLIGPymrsV52ubup?=
 =?Windows-1252?Q?cnJ9LQkGYvvB8r/k1JxatthT/j4TT9VaFO5UVLgwQ6cUYf0a3nA9Voli?=
 =?Windows-1252?Q?pT+wWkTriFAdpSP6NDPGohNDuxrFcywO5wv4LgpaTwahDJh1jYM8iWL2?=
 =?Windows-1252?Q?3vaCc9uAC/ScAd6mES64tyspcvfMIANDpIkAIDJJzpdNwcoubW+9Bodg?=
 =?Windows-1252?Q?G4mLrRvzdRqGgJGHCC2YHAMPbrgH2uzJXjMv+40n9qLBpyn3yjK+epdU?=
 =?Windows-1252?Q?Yuh/kW57LmrisKsnAyOyYIKag/ULr6EReRgqmTdtNYx4zduCYi8y2sUM?=
 =?Windows-1252?Q?id+LgICopzMV4ZLAivxjcWvTEAAYfbZVBzIvsvUtJLf3JWpbfZCwT9TW?=
 =?Windows-1252?Q?h4ImPg/OPe4Xmo0ycFYvuLctk3UR5dttAJjMg6s5D3+ZBYT7UJhb3mYY?=
 =?Windows-1252?Q?m/+ZTe6y47LhQID7lVGzyo5y3RUfmSS0Ik92IKi9RkHTkW9vgWlnYfFr?=
 =?Windows-1252?Q?pdHQnrIELxZcXJWbu7RFYrll73OdJtfbizKWobgC9Et5cJPkr5NwObeR?=
 =?Windows-1252?Q?s54n/tmfSCBwNWQZ6fofVMEpslfeiUtNaKgr+1YnYZBmKt/kQ0pWCk35?=
 =?Windows-1252?Q?C7J8DE9bdJ513LSVfR+LEYWZ+HxZ5mcClpM0OfE+tGkVzYgI+9hJQRrd?=
 =?Windows-1252?Q?ekitaNm64thFcWHJZdAxaWbEaPqUKZBHfqlUCgz7FuJmX6QH3a9Ys5UX?=
 =?Windows-1252?Q?MqkrXi8YjPe+hrTdebNxpaPadREC559kfOsA+6MromIeytbI5WO4Mg68?=
 =?Windows-1252?Q?XY/xuW0DkMRSRiXDUGQGh7z1EN9O1dngMQDS7U+1Ceuvv9x0DBmwGFS/?=
 =?Windows-1252?Q?WRfx3my7ybf2Q7dsCXaxqjdaHP2CVQT9xN4DPxGZDu++An6hpT61lsiD?=
 =?Windows-1252?Q?3x/cmbeBfJiqv3pKfKqDy+M/+cOGi/niCBoq08Ey+HSNoSIxcVRj++J0?=
 =?Windows-1252?Q?DLQNXWpmMN8h0UPI1mEljL3LiCuJ6T2CdXprnnfVc1BVTOolbGQmt9bM?=
 =?Windows-1252?Q?vms9W6MPLeuj4MggugMytrKw57h80AnJVqVv9y786jTvhHMx4W6ViXeH?=
 =?Windows-1252?Q?m/IPiOjyAPdisQ1wLjFf/LjqDX4=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4a83e5c-3240-4b37-e5b6-08d9a9f04abe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5151.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 17:32:56.2884
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2TlbgliCoj2OVwjXNsjcGMEmvxTUNr38miIOavckEq0LRt9lv9vlw9mT8GKVGlBR3YuZoaFGWO2ZPlJDypKz2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6829
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/17/21 7:29 PM, Mark Brown wrote:
> On Wed, Nov 17, 2021 at 11:37:29AM +0200, Daniel Baluta wrote:
>> From: YC Hung <yc.hung@mediatek.com>
>>
>> Add new sof dai and config to pass topology file configuration
>> to SOF firmware running on Mediatek platform DSP core.
>> Add mediatek audio front end(AFE) to the list of supported sof_dais
> This breaks an x86 allmodconfig build:
>
> /mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c: In function 'mt8195_run':
> /mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c:207:2: error: implicit declaration of function 'sof_hifixdsp_boot_sequence' [-Werror=implicit-function-declaration]
>    207 |  sof_hifixdsp_boot_sequence(sdev, adsp_bootup_addr);
>        |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
> At top level:
> /mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c:201:12: error: 'mt8195_run' defined but not used [-Werror=unused-function]
>    201 | static int mt8195_run(struct snd_sof_dev *sdev)
>        |            ^~~~~~~~~~
> cc1: all warnings being treated as errors
>
> _boot_sequence is added in "ASoC: SOF: mediatek: Add fw loader and
> mt8195 dsp ops to load firmware" which is later in the series.
>
> mt8195_run should be either global, a static inline or not declared in
> the header at all.


YC,

Please send a fix for this on top of topic/sof-dev. I will take care of 
the squash and resend.