Message-ID: <174aef7b-64ac-ab45-5283-01662dcc86ce@gmail.com>
Date:   Wed, 17 Nov 2021 19:25:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 1/3] arm64: dts: mt8183: add dpi node to mt8183
Content-Language: en-US
To:     Fabien Parent <fparent@baylibre.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Pi-Hsun Shih <pihsun@chromium.org>,
        Jitao Shi <jitao.shi@mediatek.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20211110192417.4177741-1-fparent@baylibre.com>
 <03de9880-1f1a-b07b-6ec3-279945e08cea@gmail.com>
 <CAOwMV_wmyFiSxdU7BZ-u+OLfStp+4jrwmmo-QaNvZn0HBH7Q1g@mail.gmail.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
In-Reply-To: <CAOwMV_wmyFiSxdU7BZ-u+OLfStp+4jrwmmo-QaNvZn0HBH7Q1g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/11/2021 19:21, Fabien Parent wrote:
> Hi Matthias,
> 
> 
> On Wed, Nov 17, 2021 at 6:33 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>>
>>
>> On 10/11/2021 20:24, Fabien Parent wrote:
>>> From: Pi-Hsun Shih <pihsun@chromium.org>
>>>
>>> Add dpi node to mt8183.
>>>
>>> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
>>> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
>>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>>> ---
>>>    arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
>>>    1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>> index ba4584faca5a..7c283c0b68b5 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>> @@ -1443,6 +1443,17 @@ dsi0: dsi@14014000 {
>>>                        phy-names = "dphy";
>>>                };
>>>
>>> +             dpi0: dpi@14015000 {
>>> +                     compatible = "mediatek,mt8183-dpi";
>>> +                     reg = <0 0x14015000 0 0x1000>;
>>> +                     interrupts = <GIC_SPI 237 IRQ_TYPE_LEVEL_LOW>;
>>> +                     power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
>>> +                     clocks = <&mmsys CLK_MM_DPI_IF>,
>>> +                              <&mmsys CLK_MM_DPI_MM>,
>>> +                              <&apmixedsys CLK_APMIXED_TVDPLL>;
>>> +                     clock-names = "pixel", "engine", "pll";
>>
>>
>> We are missing the output port node, don't we?
> 
> The output port node is defined in: [PATCH 2/3] arm64: dts: mediatek:
> mt8183-pumpkin: add HDMI support
> Unlike MT8173, there is no HDMI IP in the MT8183 SoC.
> 

Ok, I missed that because the thread is broken. Would you mind to just resend 
the whole series?

Thanks,
Matthias

>>
>> Regards,
>> Matthias
>>
>>> +             };
>>> +
>>>                mutex: mutex@14016000 {
>>>                        compatible = "mediatek,mt8183-disp-mutex";
>>>                        reg = <0 0x14016000 0 0x1000>;
>>>