Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030267AbXAKMii (ORCPT ); Thu, 11 Jan 2007 07:38:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030286AbXAKMii (ORCPT ); Thu, 11 Jan 2007 07:38:38 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:55954 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030267AbXAKMih (ORCPT ); Thu, 11 Jan 2007 07:38:37 -0500 Date: Thu, 11 Jan 2007 13:38:24 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: Linus Torvalds cc: Jean Delvare , Andrey Borzenkov , Andrew Morton , linux-kernel@vger.kernel.org, Andy Whitcroft , Herbert Poetzl , Olaf Hering Subject: Re: .version keeps being updated In-Reply-To: Message-ID: References: <20070109102057.c684cc78.khali@linux-fr.org> <20070109170550.AFEF460C343@tzec.mtu.ru> <20070109214421.281ff564.khali@linux-fr.org> <20070110181053.3b3632a8.khali@linux-fr.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 31 Hi, On Wed, 10 Jan 2007, Linus Torvalds wrote: > This part: > > const char __init linux_banner[] = > > CANNOT work, because the stupid SuSE tool that look into the kernel binary > searches for "Linux version " as the thing, and as such the "linux_banner" > has to be the _first_ thing to trigger it for it to work. Unless the SuSE tool is completely stupid, it should actually work: $ strings vmlinux | grep "Linux version" Linux version 2.6.20-rc3-git7 (roman@squid) (gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)) #7 SMP Wed Jan 10 14:20:10 CET 2007 $ > Which is why "__init" is wrong. It causes the linker to either put it at > the end of the thing (which would break the SuSE tool). Alternatively it > causes section mismatch problems ("init" and "const" don't work that well > together), in which case it might work, but only due to toolchain bugs. The const could be dropped, but it shouldn't hurt much either... bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/