MIME-Version: 1.0
References: <20211116013438.26517-1-bernard@vivo.com> <88328288-ef1f-ef8b-987f-43dc8dc69ee7@gmail.com>
In-Reply-To: <88328288-ef1f-ef8b-987f-43dc8dc69ee7@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 17 Nov 2021 16:37:05 -0500
Message-ID: <CADnq5_O+A8WaZv_+avrmvzt9Jjr7vwkYqnZx7-wkNtzRx0pc9A@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: cleanup the code a bit
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     Bernard Zhao <bernard@vivo.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Nov 16, 2021 at 4:19 AM Christian K=C3=B6nig
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 16.11.21 um 02:34 schrieb Bernard Zhao:
> > In function dc_sink_destruct, kfree will check pointer, no need
> > to check again.
> > This change is to cleanup the code a bit.
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> This one and the other patch are Acked-by: Christian K=C3=B6nig
> <christian.koenig@amd.com>
>
> > ---
> >   drivers/gpu/drm/amd/display/dc/core/dc_sink.c | 10 +---------
> >   1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c b/drivers/gp=
u/drm/amd/display/dc/core/dc_sink.c
> > index a249a0e5edd0..4b5e4d8e7735 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
> > @@ -33,14 +33,6 @@
> >    * Private functions
> >    ********************************************************************=
**********/
> >
> > -static void dc_sink_destruct(struct dc_sink *sink)
> > -{
> > -     if (sink->dc_container_id) {
> > -             kfree(sink->dc_container_id);
> > -             sink->dc_container_id =3D NULL;
> > -     }
> > -}
> > -
> >   static bool dc_sink_construct(struct dc_sink *sink, const struct dc_s=
ink_init_data *init_params)
> >   {
> >
> > @@ -75,7 +67,7 @@ void dc_sink_retain(struct dc_sink *sink)
> >   static void dc_sink_free(struct kref *kref)
> >   {
> >       struct dc_sink *sink =3D container_of(kref, struct dc_sink, refco=
unt);
> > -     dc_sink_destruct(sink);
> > +     kfree(sink->dc_container_id);
> >       kfree(sink);
> >   }
> >
>