Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DE5C433FE for ; Wed, 17 Nov 2021 22:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52B1761B95 for ; Wed, 17 Nov 2021 22:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241367AbhKQWgb (ORCPT ); Wed, 17 Nov 2021 17:36:31 -0500 Received: from www62.your-server.de ([213.133.104.62]:51022 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241359AbhKQWga (ORCPT ); Wed, 17 Nov 2021 17:36:30 -0500 Received: from sslproxy02.your-server.de ([78.47.166.47]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mnTUb-0008nM-IJ; Wed, 17 Nov 2021 23:33:25 +0100 Received: from [85.1.206.226] (helo=linux.home) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnTUb-000RY3-AB; Wed, 17 Nov 2021 23:33:25 +0100 Subject: Re: [PATCH 1/1] Documentation: Add minimum pahole version To: Andrii Nakryiko , Arnaldo Carvalho de Melo Cc: Jonathan Corbet , Alexei Starovoitov , Andrii Nakryiko , Jiri Olsa , bpf , Networking , Linux Kernel Mailing List References: From: Daniel Borkmann Message-ID: Date: Wed, 17 Nov 2021 23:33:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.3/26356/Wed Nov 17 10:26:25 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/21 7:21 PM, Andrii Nakryiko wrote: > On Tue, Nov 16, 2021 at 7:40 AM Arnaldo Carvalho de Melo > wrote: >> >> A report was made in https://github.com/acmel/dwarves/issues/26 about >> pahole not being listed in the process/changes.rst file as being needed >> for building the kernel, address that. >> >> Link: https://github.com/acmel/dwarves/issues/26 >> Cc: Alexei Starovoitov >> Cc: Andrii Nakryiko >> Cc: Daniel Borkmann >> Cc: Jiri Olsa >> Cc: Jonathan Corbet >> Cc: bpf@vger.kernel.org >> Cc: netdev@vger.kernel.org >> Signed-off-by: Arnaldo Carvalho de Melo >> --- >> Documentation/process/changes.rst | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst >> index e35ab74a0f804b04..c45f167a1b6c02a4 100644 >> --- a/Documentation/process/changes.rst >> +++ b/Documentation/process/changes.rst >> @@ -35,6 +35,7 @@ GNU make 3.81 make --version >> binutils 2.23 ld -v >> flex 2.5.35 flex --version >> bison 2.0 bison --version >> +pahole 1.16 pahole --version >> util-linux 2.10o fdformat --version >> kmod 13 depmod -V >> e2fsprogs 1.41.4 e2fsck -V >> @@ -108,6 +109,14 @@ Bison >> Since Linux 4.16, the build system generates parsers >> during build. This requires bison 2.0 or later. >> >> +pahole: >> +------- >> + >> +Since Linux 5.2 the build system generates BTF (BPF Type Format) from DWARF in >> +vmlinux, a bit later from kernel modules as well, if CONFIG_DEBUG_INFO_BTF is > > I'd probably emphasize a bit more that pahole is required only if > CONFIG_DEBUG_INFO_BTF is selected by moving "If CONFIG_DEBUG_INFO_BTF > is selected, " to the front. But either way looks good. +1, I presume Jonathan will later pick up the v2? > Acked-by: Andrii Nakryiko > >> +selected. This requires pahole v1.16 or later. It is found in the 'dwarves' or >> +'pahole' distro packages or from https://fedorapeople.org/~acme/dwarves/. >> + >> Perl >> ---- >> >> -- >> 2.31.1 >>