Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7AD5C433F5 for ; Wed, 17 Nov 2021 23:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA8D7619BB for ; Wed, 17 Nov 2021 23:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241718AbhKQX5X (ORCPT ); Wed, 17 Nov 2021 18:57:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:57736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232011AbhKQX5W (ORCPT ); Wed, 17 Nov 2021 18:57:22 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 45AE561BC1 for ; Wed, 17 Nov 2021 23:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637193263; bh=J1GPu/7DId0gFFkAF/P1ZlWlsNgfqyTW7Xxtk5MAF78=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eglD8/Ff5UExZHvtAFulo93AlGR43TOwdfXGjlTXeh6JfTwcn4YQkqkcchR7fPxJB aoqrwRBeUbGzum0m3nLLSoyn5kXZhD25QcjZlxiTcRijP/DvTdofvA0cr3YglS5jhc mmlBqRys0LBvZfYYJrMbZ9ouFRLM7xF90zzWpy6dAnLaisMP6vswM/F/Sgguxp3Rr5 LI6S+ntLyY96hMIphcQSpg0wqHjgjvGAMfQUml9oCwcAbDXpBY1EoamjfA1mgBBmgN JxkqlRJK+SmWafGVDHo9lqO+mFuo8OYK157544WRjNQneSPsBEY3Sueglp8fABMgPl w/Rucl0ER6DYg== Received: by mail-ed1-f49.google.com with SMTP id t5so18830988edd.0 for ; Wed, 17 Nov 2021 15:54:23 -0800 (PST) X-Gm-Message-State: AOAM530LgvCkrp3TbI7LLiE7s+wJoGU8UVsGNJgQ2ZEYRYg0/Zp7z62Q HR5778GCACO/CgJ8ClDAyzBmm6Czyve62Mu6kw== X-Google-Smtp-Source: ABdhPJwDL01kt5145UOy/pd+bJ15+XrqohhADaSRLR5cZZfZhmsCH9yL9NqWbY7R0W20QsYKqPS3G6fDF3LYKeGoFVI= X-Received: by 2002:a17:906:7955:: with SMTP id l21mr28765790ejo.6.1637193261641; Wed, 17 Nov 2021 15:54:21 -0800 (PST) MIME-Version: 1.0 References: <20211028101912.4624-1-jason-jh.lin@mediatek.com> In-Reply-To: <20211028101912.4624-1-jason-jh.lin@mediatek.com> From: Chun-Kuang Hu Date: Thu, 18 Nov 2021 07:54:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/5] CMDQ refinement of Mediatek DRM driver To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , Jassi Brar , Yongqiang Niu , Fei Shao , David Airlie , Daniel Vetter , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel , Hsin-Yi Wang , Nancy Lin , singo.chang@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jason: For this series except [v6,3/6] drm/mediatek: Detect CMDQ execution timeout (I pick v5), applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/= log/?h=3Dmediatek-drm-next Regards, Chun-Kuang. jason-jh.lin =E6=96=BC 2021=E5=B9=B410=E6=9C=88= 28=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=886:19=E5=AF=AB=E9=81=93=EF= =BC=9A > > Change in v6: > 1. Drop the redundant checking of cmdq_vblank_cnt . > 2. fix the indent. > > Change in v5: > 1. Move mbox_free_channel to a independent patch. > > Change in v4: > 1. Add cmdq_vblank_cnt initial value to 3. > 2. Move mtk_drm_cmdq_pkt_create to the same define scope with > mtk_drm_cmdq_pkt_destroy. > > Change in v3: > 1. Revert "drm/mediatek: clear pending flag when cmdq packet is done" > and add it after the CMDQ refinement patches. > 2. Change the remove of struct cmdq_client to remove the pointer of > struct cmdq_client. > 3. Fix pkt buf alloc once but free many times. > > Changes in v2: > 1. Define mtk_drm_cmdq_pkt_create() and mtk_drm_cmdq_pkt_destroy() > when CONFIG_MTK_CMDQ is reachable. > > Chun-Kuang Hu (4): > drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb > drm/mediatek: Remove the pointer of struct cmdq_client > drm/mediatek: Detect CMDQ execution timeout > drm/mediatek: Add cmdq_handle in mtk_crtc > > Yongqiang Niu (1): > drm/mediatek: Clear pending flag when cmdq packet is done > > jason-jh.lin (1): > drm/mediatek: Add mbox_free_channel in mtk_drm_crtc_destroy > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 175 ++++++++++++++++++++---- > 1 file changed, 151 insertions(+), 24 deletions(-) > > -- > 2.18.0 >