Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C16EC433EF for ; Thu, 18 Nov 2021 00:11:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7609561B98 for ; Thu, 18 Nov 2021 00:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241817AbhKRAOV (ORCPT ); Wed, 17 Nov 2021 19:14:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240630AbhKRAOT (ORCPT ); Wed, 17 Nov 2021 19:14:19 -0500 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85966C061570 for ; Wed, 17 Nov 2021 16:11:20 -0800 (PST) Received: by mail-qv1-xf29.google.com with SMTP id s9so3270636qvk.12 for ; Wed, 17 Nov 2021 16:11:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hl+jHNmt64gcmop2VJ5YRcreilaGiydQ+Rm3hJ+geuM=; b=C/ZiqA5KWRgbZsPgO6NZ5wRG/u5B1DYJCyimXTpNpDryUAx+ssN5yomcXO1RGpDY9A ixB4krsYY/nzR8gQqmIUHUmL0918qK6khE5JQ6ciLvbsemrN4PRtFl1RJ/XVy1ummekC dMqUGD4sWrobbLj1f44v7vmXIqCcGhVVMdqMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hl+jHNmt64gcmop2VJ5YRcreilaGiydQ+Rm3hJ+geuM=; b=qI/CwLT6OR0xaTFvR/XxrAaCzN2iAVG7ZnSt0m5m5jJOZd2raSOstpz4AuisDvp/JD bhvzz6MHs5iEXbIEIS8bl9hyNBS0X+cMuiZisWwKNbuAT5YmUlGUfFwna4kA5q8Mm8hl rVnpIfT5mUC31Uju5JEmP3FChW4zAOWOYeg71K8u1WWjPhoA2M7ai7f8BvG4otd9iIhS ext918Rd4eu41uYgyQ8P1KkuyCzfrRPlDP1QrafoEd+lVEAsJwJmIAXH60EMcFGJO9rL ZyRoo+KvDnzHmJccvWcgpFDHDGlK/qYZ+ENuHXaxKOy2Jq744zs3G9G8Tded3deVvAsr reFA== X-Gm-Message-State: AOAM533Y+paeDKjXGb76xLt3l5SWey/0eC4nJhHaICqlI/vXSdvkKD5g Uh04YIkiIcTCiAxdMvNc6gDj4B8vxNhExg== X-Google-Smtp-Source: ABdhPJyU9wDmu3k2UIMtM/HKkJCW9X8EzhYyIEp4jrgJZs7fCI4uHsk04LtXxpgd75NRQbsB5hl/ow== X-Received: by 2002:a05:6214:2a45:: with SMTP id jf5mr60973519qvb.50.1637194279672; Wed, 17 Nov 2021 16:11:19 -0800 (PST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com. [209.85.222.181]) by smtp.gmail.com with ESMTPSA id s11sm825468qki.95.2021.11.17.16.11.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Nov 2021 16:11:19 -0800 (PST) Received: by mail-qk1-f181.google.com with SMTP id de30so4546081qkb.0 for ; Wed, 17 Nov 2021 16:11:19 -0800 (PST) X-Received: by 2002:a05:6638:190f:: with SMTP id p15mr16966992jal.82.1637193816599; Wed, 17 Nov 2021 16:03:36 -0800 (PST) MIME-Version: 1.0 References: <20211116200739.924401-1-mka@chromium.org> <20211116120642.v17.3.I7a3a7d9d2126c34079b1cab87aa0b2ec3030f9b7@changeid> In-Reply-To: <20211116120642.v17.3.I7a3a7d9d2126c34079b1cab87aa0b2ec3030f9b7@changeid> From: Doug Anderson Date: Wed, 17 Nov 2021 16:03:25 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v17 3/7] usb: core: hcd: Create platform devices for onboard hubs in probe() To: Matthias Kaehlcke Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Stephen Boyd , Peter Chen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Roger Quadros , Michal Simek , Ravi Chandra Sadineni , Bastien Nocera , Andrey Konovalov , Kishon Vijay Abraham I , Li Jun , Peter Chen , Sasha Levin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Nov 16, 2021 at 12:07 PM Matthias Kaehlcke wrote: > > Call onboard_hub_create/destroy_pdevs() from usb_add/remove_hcd() > for primary HCDs to create/destroy platform devices for onboard > USB hubs that may be connected to the root hub of the controller. > These functions are a NOP unless CONFIG_USB_ONBOARD_HUB=y/m. > > Also add a field to struct usb_hcd to keep track of the onboard hub > platform devices that are owned by the HCD. > > Signed-off-by: Matthias Kaehlcke > --- > > Changes in v17: > - create the platform devices in the generic HCD code instead of > the xhci_platform driver > - updated subject and commit message to reflect the above change > - dropped initialization of platform device list, which is now > done in onboard_hub_create_pdevs() > > Changes in v16: > - none > > Changes in v15: > - none > > Changes in v14: > - none > > Changes in v13: > - added comment for 'depends on USB_ONBOARD_HUB || !USB_ONBOARD_HUB' > construct > > Changes in v12: > - none > > Changes in v11: > - use onboard_hub_create/destroy_pdevs() to support multiple onboard > hubs that are connected to the same root hub > - moved field/list to keep track of platform devices from struct > usb_hcd to struct xhci_hcd > - updated commit message > > Changes in v10: > - none > > Changes in v9: > - added dependency on USB_ONBOARD_HUB (or !!USB_ONBOARD_HUB) to > USB_XHCI_PLATFORM > > Changes in v8: > - none > > Changes in v7: > - none > > Changes in v6: > - none > > Changes in v5: > - patch added to the series > > drivers/usb/core/hcd.c | 6 ++++++ > include/linux/usb/hcd.h | 1 + > 2 files changed, 7 insertions(+) This looks sane to me, so: Reviewed-by: Douglas Anderson That being said, I don't know these functions and can't say with any authority that this is the "right" place to put the onboard_hub_create_pdevs() and onboard_hub_destroy_pdevs(). I'm assuming that Alan, Greg, or someone else on this CC list will scrutinize that more closely and make sure where Matthias picked is OK. -Doug