MIME-Version: 1.0
In-Reply-To: <YZU7EdoJmvisai+z@jeremy-acer>
References: <5831447.lOV4Wx5bFT@natalenko.name> <CAKYAXd-KmxMeYWP8z6RYYK6za-Sj81Qtb3RO=oG+Yy3kXDaLjg@mail.gmail.com>
 <2865530.e9J7NaK4W3@natalenko.name> <CAKYAXd9wKDTE5WPQWcBZ_mHfaAOOY+pDj7=yndi17gf2KqWpwg@mail.gmail.com>
 <YZU7EdoJmvisai+z@jeremy-acer>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Thu, 18 Nov 2021 09:31:16 +0900
Message-ID: <CAKYAXd9TTH+Nv5ebH6CYjZfwtwgy37uo5+XER4pT9=SPdJ0hnw@mail.gmail.com>
Subject: Re: ksmbd: Unsupported addition info
To:     Jeremy Allison <jra@samba.org>
Cc:     Oleksandr Natalenko <oleksandr@natalenko.name>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        Hyunchul Lee <hyc.lee@gmail.com>, linux-cifs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021-11-18 2:25 GMT+09:00, Jeremy Allison <jra@samba.org>:
> On Wed, Nov 17, 2021 at 06:58:50PM +0900, Namjae Jeon wrote:
>>2021-11-17 16:00 GMT+09:00, Oleksandr Natalenko
>> <oleksandr@natalenko.name>:
>>> Hello.
>>>
>>> On st=C5=99eda 17. listopadu 2021 0:36:53 CET Namjae Jeon wrote:
>>>> 2021-11-17 6:44 GMT+09:00, Oleksandr Natalenko
>>>> <oleksandr@natalenko.name>:
>>>> > With the latest ksmbd from the next branch I have an issue with
>>>> > wife's
>>>> > Windows
>>>> > 10 laptop while copying/removing files from the network share. On he=
r
>>>> > client it
>>>> > looks like copy operation (server -> laptop) reaches 99% and then
>>>> > stalls,
>>>> > and
>>>> > on the server side there's this in the kernel log:
>>>> >
>>>> > ```
>>>> > ksmbd: Unsupported addition info: 0xf)
>>>> > ksmbd: Unsupported addition info: 0x20)
>
Hi Jeremy,
> Namjae, looks like your code is handling the
> following flags in query security descriptor:
>
>          if (addition_info & ~(OWNER_SECINFO | GROUP_SECINFO | DACL_SECIN=
FO
> |
>                                PROTECTED_DACL_SECINFO |
>                                UNPROTECTED_DACL_SECINFO)) {
>                  pr_err("Unsupported addition info: 0x%x)\n",
>                         addition_info);
>
>  From the Samba code we have (the names are pretty
> similar):
>
>          /* security_descriptor->type bits */
>          typedef [public,bitmap16bit] bitmap {
>                  SEC_DESC_OWNER_DEFAULTED        =3D 0x0001,
>                  SEC_DESC_GROUP_DEFAULTED        =3D 0x0002,
>                  SEC_DESC_DACL_PRESENT           =3D 0x0004,
>                  SEC_DESC_DACL_DEFAULTED         =3D 0x0008,
>                  SEC_DESC_SACL_PRESENT           =3D 0x0010,
>                  SEC_DESC_SACL_DEFAULTED         =3D 0x0020,
>                  SEC_DESC_DACL_TRUSTED           =3D 0x0040,
>                  SEC_DESC_SERVER_SECURITY        =3D 0x0080,
>                  SEC_DESC_DACL_AUTO_INHERIT_REQ  =3D 0x0100,
>                  SEC_DESC_SACL_AUTO_INHERIT_REQ  =3D 0x0200,
>                  SEC_DESC_DACL_AUTO_INHERITED    =3D 0x0400,
>                  SEC_DESC_SACL_AUTO_INHERITED    =3D 0x0800,
>                  SEC_DESC_DACL_PROTECTED         =3D 0x1000,
>                  SEC_DESC_SACL_PROTECTED         =3D 0x2000,
>                  SEC_DESC_RM_CONTROL_VALID       =3D 0x4000,
>                  SEC_DESC_SELF_RELATIVE          =3D 0x8000
>          } security_descriptor_type;
>
> 0xF =3D=3D
> (SEC_DESC_OWNER_DEFAULTED|SEC_DESC_GROUP_DEFAULTED|SEC_DESC_DACL_PRESENT|=
SEC_DESC_DACL_DEFAULTED)
>
> and:
>
> 0x20 =3D=3D SEC_DESC_SACL_DEFAULTED
>
> Looks like you need to handle these bits.
>
> Hope this helps,
Let me check it. Thanks for your mail:)
>
> Jeremy.
>