From:   Bernard Zhao <bernard@vivo.com>
To:     Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
        Edmund Dea <edmund.j.dea@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] drm/kmb: fix potential memleak in error branch
Date:   Wed, 17 Nov 2021 18:37:23 -0800
Message-Id: <20211118023723.85553-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J7aq23QM/AiinhAfFLdwhsaPA6OMM7XiXXqsZxufq209aK+T7uGFhRtbdJIP?=
 =?us-ascii?Q?hwGwGdD7WAV0RswffhpoYOdiCy2+WwV8u9cyUxUNkA4RmjfLep99CN2hrZyz?=
 =?us-ascii?Q?bStq/QPbRmLd12qk61hYWGfqHdGYFS0g3/I0lG8EL+lNzSKbalCzqMDM3aRT?=
 =?us-ascii?Q?EZ0K27BTIiNFK3M6bgdAfvAbJqW3Cf1vQZ3GzBHacIXyXsXVCCO5KqJmzTMO?=
 =?us-ascii?Q?URFmsV9T710XkVnDHeUyTp03YyS04QyrNX7GonI4UG06vxhBQQjzNkC5tct2?=
 =?us-ascii?Q?kuUDneAGObvdVI7Y9F6rxPHLFEm1tehsr5+amZDfaUx0ge/c/bZo0ByNTcEx?=
 =?us-ascii?Q?+YLTNOoCqb73DSjxMxFFyhUT/MBAD4beac1mZFNqwy/nUyGpfM4zGXO2LRSM?=
 =?us-ascii?Q?I5BOTAUWjtV2utg1Ktl1kbJi29x+hGN4LENesADuTFnqa9lVUgES+bqir6e4?=
 =?us-ascii?Q?WH/7hFpEfo1Ks2bR8Z4ugs44fdGUbNDXlDn9cXB0b4w+nkqUSkN//qFyovQp?=
 =?us-ascii?Q?mNQpT9xDMClCsUgm9+Yw0Yevn9UnpA+uIIImQBFsSxzBDt0ApYm2uOxt/nHR?=
 =?us-ascii?Q?kC7j9Eo+s0nvJFD9mUOEp8drrzmQpR7aaD7MrQXkLycakpEJ06nZnt4tP0pe?=
 =?us-ascii?Q?5gpXRMaPzgyK8g7zD/5N3njlAKlhk+DsryuvFNnLmtdi9cwPu7I1Jtvk4sQL?=
 =?us-ascii?Q?kGG33/QGfYhkG5G8o/9uGjs/xLaejOw1FeFhJoHrSS3CoawrgXkfggvWrx/S?=
 =?us-ascii?Q?AVzCxvWIiw3+wEI70i0+LROBBOAikkgiODNQ1SACEL2rAkUKRpO2T2DwrLPt?=
 =?us-ascii?Q?NA38wrOzfZ2auD/ZdcvkBKhAf2t3wciGI4s9tJ6cNjDHB7mElIFEouEe2H43?=
 =?us-ascii?Q?c1bTrfqRiqFjMxg3a4Etiv4ZoMdX1H1P478odpFC/mCVjUO2yaO07h7gLVtx?=
 =?us-ascii?Q?tiygvcZ4UgZPZMnffronUqwn2A6ZFRyPbyfEjcXkkJuTI9ET/RAv4UUppHY1?=
 =?us-ascii?Q?TzE9pLh92v11VYeB+j9OO6sm0mkw9GCVezsYtApoJ3sFxgvqs5IaqlbarxMw?=
 =?us-ascii?Q?guhloQS2TI7aw2xHPBhTlIt7lzJmhR2pTwsCVxJzjRg+ErK4NQWb27yI5ySX?=
 =?us-ascii?Q?eq4jsVOfR95DLnKb06zOgPT7/hDj3RDVdj7twWo3ClyRwoewewOlK9AkKDe8?=
 =?us-ascii?Q?ALLibht4W7AU0kUfa9B5KfgQrsuJDbjYYBMt0WyX3qlftAwH5pkCMRW3n928?=
 =?us-ascii?Q?69fUirItMA4Oc6mhbAGFCosCdfOHEEgEVgR0GLoqdBapHntUp3ylUxP9MlGW?=
 =?us-ascii?Q?guIe6s1IDnkqC6VsMgluZYIFq6aScaUkZ1a1/4HBVe7kdbP/FDVeXISq1I+6?=
 =?us-ascii?Q?3pvEQmint/8x65+FVLZfzQTAApukIMHRNUrs21Sb1gWsivbBma2nCY73YN8l?=
 =?us-ascii?Q?9F7hgkxR4P1NTWtbyg7Yk2Zzd7Z2hJEAwArF8l2fhZ7rteW0FcpupIRUHeqs?=
 =?us-ascii?Q?KODcNkmyU9uQqwjKPwpIHk3EniEtUv8NWFaVX7eMXgFdJrX3H2BPxApIfTsr?=
 =?us-ascii?Q?JJn6mfLH+kev0Uwvb9ScmdY8qg9ZGUc730+6aFHt9JUJIu69ID3WRafq2vn9?=
 =?us-ascii?Q?tg83aYO5/D+CYHa0IRntlcA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb1e99fb-dd8e-4137-f5c5-08d9aa3c60f7
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 02:37:35.9960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lbkOziH8LBEJ7zTOzzq3ud68Ji5o70E5Er9GWko725mITULHzyEWLzhATsU2ooI+KRdH54BW3W4Gz+oFFgZZOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2902
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch try to fix coccicheck warning:
./drivers/gpu/drm/kmb/kmb_drv.c:519:2-8: ERROR: missing put_device; call of_find_device_by_node on line 506, but without a corresponding object release within this function.
./drivers/gpu/drm/kmb/kmb_drv.c:522:2-8: ERROR: missing put_device; call of_find_device_by_node on line 506, but without a corresponding object release within this function.
./drivers/gpu/drm/kmb/kmb_drv.c:529:2-8: ERROR: missing put_device; call of_find_device_by_node on line 506, but without a corresponding object release within this function.
./drivers/gpu/drm/kmb/kmb_drv.c:579:1-7: ERROR: missing put_device; call of_find_device_by_node on line 506, but without a corresponding object release within this function.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/kmb/kmb_drv.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 961ac6fb5fcf..4a7178288ecf 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -514,8 +514,10 @@ static int kmb_probe(struct platform_device *pdev)
 	ret = kmb_dsi_host_bridge_init(get_device(&dsi_pdev->dev));
 
 	if (ret == -EPROBE_DEFER) {
+		of_dev_put(dsi_pdev);
 		return -EPROBE_DEFER;
 	} else if (ret) {
+		of_dev_put(dsi_pdev);
 		DRM_ERROR("probe failed to initialize DSI host bridge\n");
 		return ret;
 	}
@@ -523,8 +525,10 @@ static int kmb_probe(struct platform_device *pdev)
 	/* Create DRM device */
 	kmb = devm_drm_dev_alloc(dev, &kmb_driver,
 				 struct kmb_drm_private, drm);
-	if (IS_ERR(kmb))
+	if (IS_ERR(kmb)) {
+		of_dev_put(dsi_pdev);
 		return PTR_ERR(kmb);
+	}
 
 	dev_set_drvdata(dev, &kmb->drm);
 
@@ -572,6 +576,8 @@ static int kmb_probe(struct platform_device *pdev)
 	dev_set_drvdata(dev, NULL);
 	kmb_dsi_host_unregister(kmb->kmb_dsi);
 
+	of_dev_put(dsi_pdev);
+
 	return ret;
 }
 
-- 
2.33.1