Message-ID: <a8d9f99d-8aa8-3186-fcca-c0f7b7f37327@gmail.com>
Date:   Wed, 17 Nov 2021 20:59:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.1
Subject: Re: [PATCH v2] ipv4/raw: support binding to nonlocal addresses
Content-Language: en-US
To:     Riccardo Paolo Bestetti <pbl@bestov.io>,
        Denis Kirjanov <dkirjanov@suse.de>
Cc:     David Ahern <dsahern@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <CFSH0AY7X60L.1KW9K4CV82NQG@enhorning>
From:   David Ahern <dsahern@gmail.com>
In-Reply-To: <CFSH0AY7X60L.1KW9K4CV82NQG@enhorning>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/17/21 5:14 PM, Riccardo Paolo Bestetti wrote:
>>> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
>>> index 1e44a43acfe2..e540b0dcf085 100644
>>> --- a/net/ipv4/ping.c
>>> +++ b/net/ipv4/ping.c
>>> @@ -311,15 +311,11 @@ static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
>>>   		pr_debug("ping_check_bind_addr(sk=%p,addr=%pI4,port=%d)\n",
>>>   			 sk, &addr->sin_addr.s_addr, ntohs(addr->sin_port));
>>>   
>>> -		if (addr->sin_addr.s_addr == htonl(INADDR_ANY))
>>> -			chk_addr_ret = RTN_LOCAL;
>>> -		else
>>> -			chk_addr_ret = inet_addr_type(net, addr->sin_addr.s_addr);
>>
>> That was done intentionally in commit 0ce779a9f501
>>
> 
> Should I remove this from the patch? Is there a particular reason why
> this was done in ping.c but not in the other places?
> 

exactly. I did not see the big deal about changing it.