MIME-Version: 1.0
References: <20211117152952.12271-1-sergio.paracuellos@gmail.com> <YZVwtUO/j/ZYaL3q@rocinante>
In-Reply-To: <YZVwtUO/j/ZYaL3q@rocinante>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Thu, 18 Nov 2021 06:08:21 +0100
Message-ID: <CAMhs-H9KQbW=SQCyuR4008NPt8dWpGYspHTwJRRAeoi7Z1ygRg@mail.gmail.com>
Subject: Re: [PATCH] PCI: mt7621: declare 'mt7621_pci_ops' static
To:     =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>
Cc:     linux-pci <linux-pci@vger.kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Krzysztof,

On Wed, Nov 17, 2021 at 10:14 PM Krzysztof Wilczy=C5=84ski <kw@linux.com> w=
rote:
>
> Hi,
>
> > Sparse complains about 'mt7621_pci_ops' symbol is not declared and asks=
 if
> > it should be declared as 'static' instead. Sparse is right. Hence decla=
re
> > symbol as static.
>
> Thank you for taking care of this!
>
> [...]
> > -struct pci_ops mt7621_pci_ops =3D {
> > +static struct pci_ops mt7621_pci_ops =3D {
> >       .map_bus        =3D mt7621_pcie_map_bus,
> >       .read           =3D pci_generic_config_read,
> >       .write          =3D pci_generic_config_write,
>
> Thank you!
>
> Reviewed-by: Krzysztof Wilczy=C5=84ski <kw@linux.com>

Thanks!

Best regards,
     Sergio Paracuellos

>
>         Krzysztof