Date:   Thu, 18 Nov 2021 13:43:46 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Tzung-Bi Shih <tzungbi@google.com>
Cc:     narmstrong@baylibre.com, dan.carpenter@oracle.com,
        robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
        jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie,
        daniel@ffwll.ch, sam@ravnborg.org, pihsun@chromium.org,
        maxime@cerno.tech, drinkcat@google.com, hsinyi@chromium.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        bliang@analogixsemi.com, qwen@analogixsemi.com
Subject: Re: [PATCH] drm/bridge: anx7625: Check GPIO description to avoid
 crash
Message-ID: <20211118054346.GA3796880@anxtwsw-Precision-3640-Tower>
References: <20211118031125.3778969-1-xji@analogixsemi.com>
 <CA+Px+wUc8+5HtkS8y4b9aw7m+wLS+zC1em6VKRNog1QKnJrZ=Q@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+Px+wUc8+5HtkS8y4b9aw7m+wLS+zC1em6VKRNog1QKnJrZ=Q@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MeIV+gNDXuugK3GCXHE0KdR6fccTF9aI/zY7BbaK6sAx+RMbjuSuDLmECN/K?=
 =?us-ascii?Q?no+Cl/AHWJN66O838nsItEp0lFK5WlEurtSrLvz29Y93PY6GtuBgDPSJFZ1y?=
 =?us-ascii?Q?FBEpIut2Aac2K3U/dMB0lKX+iIr+u4jCk89Lnmsq3zwWEUwUr1bvXilyc61U?=
 =?us-ascii?Q?Z1zOnIFGIFXEypiWLjp5EUBRVFmF8zCAb2VlbLSnhGoIBuuS64xBSx/jSVRM?=
 =?us-ascii?Q?GsTbvUNDNXVq0qjfDlgtlz/VhmSoTtjgRB6N3wPV0bDTEl+QsDq8XzSgD1EI?=
 =?us-ascii?Q?tmK84uh7gqKWZm/PRr4GzNptsMQQenLdD2PVGi+5VyY0GN+FtcyUQju98ssC?=
 =?us-ascii?Q?8ueV+QoORhgvh0ZFk2X15YUjzZWpaE+2D4LKoF3R5YDlRqXOQGzs6Oc9Vt9c?=
 =?us-ascii?Q?aXEGRKT3ubbmUeQ8rI4AGHUpDp9fCCZdGO6uXyuYdlYOhViNwqAyapnh2i0d?=
 =?us-ascii?Q?j+DXAJV0IucivoALmmHF8/dINdtovpRTh9IzGCh7W0YA/mIX/052Dbt1HMir?=
 =?us-ascii?Q?IuJwoSzd6cXx+usnHKOT5HLifzh0H6S0zD2rORguXhvadUDzthNVNL1iB0qm?=
 =?us-ascii?Q?xiF/uUQ/tayjyfj9GxgE090Vxy23jqiu3lc3IqBnGKsKY0eebDd1hG2WyaWv?=
 =?us-ascii?Q?jc1OFGfohIqKsUPiVxbVIsVz5mN/BDUspH0plmzA9Gh5YuIfYjUg8Rl9Uhtc?=
 =?us-ascii?Q?NrI9i+MQrJNrlGeAHwM67Q3DSbCkLvtFFIsRUvN+imZtIl4eSLHKCOLKzLJI?=
 =?us-ascii?Q?lz5Ouatog3qgrP88/1CCaL873HinQHx5ehJEMvxKusXBl3GLUwPpNz6c/XvD?=
 =?us-ascii?Q?DLOKDWIkkVDPp0yDxxfNvadOGZioxtdXQdF7Y6gUx/JuAwsXD1Q9WA4MgjUL?=
 =?us-ascii?Q?iFSB9J07eXHhTAfAJu9WAPKBDGsTuTE1W15Q8b0NiLzlrZSni3yACAcbxccL?=
 =?us-ascii?Q?JWjRYPkj8Yycw9JB0fbjt+rVczYtwuXFPtQ/cfHbRoiHr2VROjrHAjPZW6cy?=
 =?us-ascii?Q?92lacVo0+zgqe9yaHEybRnrt4z6Yka0TBBWExC8v4vFSSs2/Br96haWSjbvc?=
 =?us-ascii?Q?9ldZOKVY+tQVy1yBxdqjA8oFuGAmILIgnMz/D0ljTUiVjtAI0xT5q/7B8bfE?=
 =?us-ascii?Q?HT1SAndoEFGNHF47PBXwqo4gHO8+LEV77EF9Frw1vil9p8VKi1+9hGAibjZc?=
 =?us-ascii?Q?GeJUBRoaU5ykMfo+g9aX1AoyIXnZywGPJVhlHd05HH5/RL7zKqem5BmOAjdj?=
 =?us-ascii?Q?NLP+aeMW5eZzxUcjPwIue/80NCi8Qkamdo6iv3FnoeYPI0+NFBKND47DQB4d?=
 =?us-ascii?Q?3px2gt/HJv72u+y2iAHZ5XcH69gYB9Wh5dnsCos47dw6HFaPP5ZRk1gitajY?=
 =?us-ascii?Q?tDVEPyKAoprYkmBW/YrkAuDVuFcbBzv4Oe8YgLhce8MAYOdXh+TbIESLo6/+?=
 =?us-ascii?Q?0S0ljFIHN4WDgT8W11mfr5Q98T6HuibvvkizzZj4JrRLokMYRVgM4BII9cyX?=
 =?us-ascii?Q?qyDtkKBls0tl8qfhCLWoF9Fd/XDnq5qhDEVwBulqs1DO8rdTOeg5wLoRXfcW?=
 =?us-ascii?Q?UxseAlZH22RK0btgEiFxvR9SuBWx1VtTEPbSaL3WkPyZ5gfsPwvMlqkv+Bg4?=
 =?us-ascii?Q?Y4HNybVfKddpQqBQvOqrQVk=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9c039a4-e390-4bbc-e352-08d9aa56684f
X-MS-Exchange-CrossTenant-AuthSource: CH2PR04MB6741.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 05:43:54.6667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PqaNfmik9uWgaAVqD/AzBHFgZv3MrP20KMGh2/ujcIzVxvMnWHpjeNUm9zUu3OS17Ez4iU66cuq8KraK8IMIVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6710
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 18, 2021 at 12:52:14PM +0800, Tzung-Bi Shih wrote:
> On Thu, Nov 18, 2021 at 11:11 AM Xin Ji <xji@analogixsemi.com> wrote:
> > @@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data *platform)
> >         /* Gpio for chip power enable */
> >         platform->pdata.gpio_p_on =
> >                 devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
> > +       if (IS_ERR(platform->pdata.gpio_p_on)) {
> > +               DRM_DEV_DEBUG_DRIVER(dev, "no enable gpio found\n");
> > +               platform->pdata.gpio_p_on = NULL;
> > +       }
> > +
> >         /* Gpio for chip reset */
> >         platform->pdata.gpio_reset =
> >                 devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> > +       if (IS_ERR(platform->pdata.gpio_reset)) {
> > +               DRM_DEV_DEBUG_DRIVER(dev, "no reset gpio found\n");
> > +               platform->pdata.gpio_p_on = NULL;
> > +       }
> >
> >         if (platform->pdata.gpio_p_on && platform->pdata.gpio_reset) {
> >                 platform->pdata.low_power_mode = 1;
> 
> devm_gpiod_get_optional() is possible to return NULL (see
> https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.15.2%2Fsource%2Fdrivers%2Fgpio%2Fgpiolib-devres.c%23L250&amp;data=04%7C01%7Cxji%40analogixsemi.com%7C40e84a44676149c2544a08d9aa4f37f0%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637728079481953910%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=2UPuAadtM%2FObwkwE6fLhJr7uCfWN%2Fr29o4t8uqUU2Ls%3D&amp;reserved=0).
> Thus, we should use IS_ERR_OR_NULL for checking the return value.
Hi Tzung-Bi Shih, IS_ERR_OR_NULL is better, I'll use it.

Thanks,
Xin
> 
> The cases here would work fine except it will skip to print some
> informative messages.
> 
> Acked-by: Tzung-Bi Shih <tzungbi@google.com>