From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     daniel@iogearbox.net
Cc:     andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
        davemarchevsky@fb.com, guozhengkui@vivo.com,
        john.fastabend@gmail.com, kafai@fb.com, kernel@vivo.com,
        kpsingh@kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
        shuah@kernel.org, songliubraving@fb.com, sunyucong@gmail.com,
        yhs@fb.com
Subject: Re: [PATCH] selftests/bpf: fix array_size.cocci warning
Date:   Thu, 18 Nov 2021 15:11:28 +0800
Message-Id: <20211118071128.13519-1-guozhengkui@vivo.com>
In-Reply-To: <8f387f33-51f7-feea-d366-ceb5bbed0b51@iogearbox.net>
References: <8f387f33-51f7-feea-d366-ceb5bbed0b51@iogearbox.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TAYE/r2fTuFIk2UYs2cdJwrnyaiBA8sMTw/eAPS74RZh3Ay4rLdJ/iFpgdrE?=
 =?us-ascii?Q?AnS0izd7nxDfJnU9kiZQ5Mnqks8xm8iWS1jM6WbKDkjuORtNP+3R7nzrdwT3?=
 =?us-ascii?Q?xpZzWOjuK9gZMHi87FRUleZCX4CsKi3TrspT7Fc2SnTv7NYaIzTtsKaU7tBU?=
 =?us-ascii?Q?AE8hO/Waf8wNaV7/0BW8jDoxeR/HZ9TtbYMTbSrOdQsk4zs+flne2Do23K2S?=
 =?us-ascii?Q?17zMYuUw1wjQw1hQ4NeBAmJ6Qi7UBiih/hexDVCTqQGwxZL1l4QjGc4HukYv?=
 =?us-ascii?Q?bRHdc0wma/MsZwjW3sT0ZtifuaMJK20i/b+L3WYHcm2587sw+YBlAvEjluel?=
 =?us-ascii?Q?PcN7GtVPIi9ba3sCR0Tz831OZBKnu9hJS/+o5kBmjYLzLmsMCowwNUVIE8Gp?=
 =?us-ascii?Q?SsgVMylPMDCbmV/847U9PFwK+EH8g+j7nRMCn4z7OA+Lvafwbnsizacut0oC?=
 =?us-ascii?Q?EC44FkDsU/qrteK6o1VmFsG71j0DaByuCjG6GY8Jrtm0M5NHrhiFW8xupEZH?=
 =?us-ascii?Q?CUj0Fv87rANDvbiq/+OpSdtY0/H3SRMLZM8KpQHnxR2W4FpW4YWoYjKCFei0?=
 =?us-ascii?Q?tYixohtSHu2P5/xhbrvzQ/QtlTXSEsxdWDYripZdLJIBt+wbdqZvOxkvhg6Z?=
 =?us-ascii?Q?01hYPTL87CNj+OwbMUC7T/qu93WfGCfvqhK6qgCaMW9tytjnVQfzXAOkjxxp?=
 =?us-ascii?Q?liQENC4XoSEHvFCoRojGU2N6fTeJkbZYE/3hAVbmyHYIIN0XNwV3/1IevZ2o?=
 =?us-ascii?Q?Qlfq+Ptl6rI77e9TfFrWT2NjYwO5k7Pg0ZWPuXo7rZSHiY9H2zFD6RA2XoFz?=
 =?us-ascii?Q?YUSx8oaBw5k+6a7q6q1Hs8kCP+JJM+LhB7MelYZDe387YWzglzyExXxId5Xy?=
 =?us-ascii?Q?wtupuUfjmakLHlHPRt+7aMBNWOA2N7+Xj8OdyIl4TDhcyh6TYfa49CTdeNjD?=
 =?us-ascii?Q?Aq/+ym93q6smcX8vB+4qb0Qfm2Riv87tzqw6TmUcuLEI7afLyj2sOfVTKOtF?=
 =?us-ascii?Q?tZ64SMkcuuUvlPLC4NLLuw31+ndG4m/A55T56MmLmgkcsdTvh0KyL/3xmeIN?=
 =?us-ascii?Q?cCHb5xhtQBDBoDQXwllt6nE/kFyWRDRvaVU1oSDnbVa6GA/ISWD3PkvdOxwZ?=
 =?us-ascii?Q?XSOEzBbipNKijkh0RGQaA9xR/fNqhaS51HpECdb+jJY6fkMCwwAKkJrI9jlr?=
 =?us-ascii?Q?SPT0tq/n+ZGSI37RVjdhH+7Oe9FLqmZL4f+2hcdWnY1XmzaIDIhPvLBz7JDb?=
 =?us-ascii?Q?gbHF3m9WBZBUqj2LbNznnbulnGUIn083G3r25EzKvdJacDCZXTYuFW2dAUDD?=
 =?us-ascii?Q?MoWtW8G41tWHxbIECOk47SSYb92A5ZUJwc3LsVh8yPf1GP/83tqKsPT00/MK?=
 =?us-ascii?Q?Zh4Mcf5adCVMYuNYJ9LG10beMdqWNECZYlPBlz2zmnceaiWiEd5biWQtNGoW?=
 =?us-ascii?Q?OkPUjSo8SX6QoMIGZM/VvdGJ7p/O9bGqOVLKlJ8dA+96c3GDHXVtJCVxo9JH?=
 =?us-ascii?Q?z0Sww7QTGEUgGDXUMqrVU0DFUuNjm+vSaJ+lNpzgl9kbEGp40l53taCq1TpU?=
 =?us-ascii?Q?M9tze/FGekaZFD9gCK0Kyr0UrPyCl5igOOp6eONhW4jm8UMglHUj2Jqh+6ow?=
 =?us-ascii?Q?+NFWW90HW5jCk7alkqA2hVA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b5de4e9-9d14-4a22-add6-08d9aa62ac01
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 07:11:42.4091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R8dASP/AAiCD/f8T7QPbK22aWDqUiMO0/1M95G2UwhSvVKVAKlPiYJIhXDZYR4a3ssAUDfZzKbBOMicCROVqkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB3427
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> No need for the extra include. test_progs.h already includes bpf_util.h, please check
> such trivialities before submission. Simple grep would have revealed use of ARRAY_SIZE()
> in various places under tools/testing/selftests/bpf/prog_tests/.

Actually, ARRAY_SIZE() in ./include/linux/kernel.h is diffrent from the one defined in bpf_util.h:

./include/linux/kernel.h
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))

./tools/testing/selftests/bpf/bpf_util.h
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

__must_be_array() ensures arr is an array, which is better than the one defined in bpf_util.h

> here are many more similar occurrences. Please just send one cleanup patch to reduce churn in the git log.

Yes, I will commit another patch.