From:   Stephan Mueller <smueller@chronox.de>
To:     Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc:     herbert@gondor.apana.org.au, ebiggers@kernel.org,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        keyrings <keyrings@vger.kernel.org>, simo@redhat.com
Subject: Re: [PATCH v3 3/4] security: DH - remove dead code for zero padding
Date:   Thu, 18 Nov 2021 09:37:01 +0100
Message-ID: <6300797.NZM0BCWY22@tauon.chronox.de>
In-Reply-To: <f98dbf21-50d1-7847-18cb-2f5093a8ac8@linux.intel.com>
References: <2589009.vuYhMxLoTh@positron.chronox.de> <3323567.LZWGnKmheA@positron.chronox.de> <f98dbf21-50d1-7847-18cb-2f5093a8ac8@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Am Mittwoch, 17. November 2021, 22:28:46 CET schrieb Mat Martineau:

Hi Mat,

> On Mon, 15 Nov 2021, Stephan M=FCller wrote:
> > Remove the specific code that adds a zero padding that was intended
> > to be invoked when the DH operation result was smaller than the
> > modulus. However, this cannot occur any more these days because the
> > function mpi_write_to_sgl is used in the code path that calculates the
> > shared secret in dh_compute_value. This MPI service function guarantees
> > that leading zeros are introduced as needed to ensure the resulting data
> > is exactly as long as the modulus. This implies that the specific code
> > to add zero padding is dead code which can be safely removed.
> >=20
> > Signed-off-by: Stephan Mueller <smueller@chronox.de>
> > ---
> > security/keys/dh.c | 25 ++++---------------------
> > 1 file changed, 4 insertions(+), 21 deletions(-)
>=20
> Hi Stephan -
>=20
> Thanks for the cleanup!

Thank you for the review.
>=20
> Acked-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

I have added your signature to the patch.

Ciao
Stephan