Message-ID: <304efdfe-db6e-051e-b61d-e73a8dfa1c53@axentia.se>
Date:   Thu, 18 Nov 2021 10:36:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: =?UTF-8?B?UmU6IFtQQVRDSCB2MSAxLzNdIGkyYzogbXV4OiBncGlvOsKgUmVwbGFj?=
 =?UTF-8?Q?e_custom_acpi=5fget=5flocal=5faddress=28=29?=
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Evan Green <evgreen@chromium.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Peter Korsgaard <peter.korsgaard@barco.com>
References: <20211115154201.46579-1-andriy.shevchenko@linux.intel.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20211115154201.46579-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2xhdzczZzJIQ2J3TWdCcm5HajdORStsZytNa0pieDN0QmNqSXp3OThpVlM1?=
 =?utf-8?B?U0JNVEt1YW9qek5NU0Z1a2JEV1UySzVrYW12aUF2RFhYMjArM3ZQRFBxVkZW?=
 =?utf-8?B?ajhvVU5QNVBHQXliNTJodDR3c1dkcFR2TDhKMS9LTkhPZzNqOW1ocDZkdS9D?=
 =?utf-8?B?ZnJFUlBwOVgwc2U1OFcrWTFHVDlmTVFwL0RJaWZJeUxYRXAvVnNWb3JtbTNO?=
 =?utf-8?B?TUxiVHI2Qi8yWWIyS254TkUzN1RKSWdtM09HNS9tR3dYeVZ1VWw2eUpuZjM4?=
 =?utf-8?B?WTNMam5JdUFyWll4cTJHZ1RZSXlFY1lteWdwdWlxSFBrVlBhblZMNjhGVzg1?=
 =?utf-8?B?cW5uRzNzWmJmc05kVFVlVkdhUlUzRUVnYmwzdXRBZmdJalZRNkdnbENxaXVQ?=
 =?utf-8?B?dGFGaStEMnhxNFRjcWp5QWlld2oyVTI4TGhVRngzbXNsRkQ1K08vMEdFeUxC?=
 =?utf-8?B?K1h1SW5jaEkvVzgwOFdHUUNUSm1EbTFxeDVLV0lueXQ2a3RCSXk2eEtkekZX?=
 =?utf-8?B?SEtvT25xWXJXK25LUzhTQTcvSVdRMzlVSE5Xd29KZG9zK01vNHlaT1BQeERj?=
 =?utf-8?B?bWJTZS9Lcm92bzZRZUtrK2daN3prU0kySVRrNUNFakZJTzBRRXpDaTcvWmFX?=
 =?utf-8?B?blpRMDZtMXM5L2dhOWlvbElvMThTUi82VldyT0w5ZXhnd3pVdlg2R3k5aVdW?=
 =?utf-8?B?WHdwRWNIZUxFdVFQSnB5SXZXSHpTSEdEaFd0VmJJY2p5Y1k5dUl5aGFBN2tY?=
 =?utf-8?B?OFk5TkI4TVhlYXE3dEJodjN2TzYzTEhxdldhTFFJKzIrWXBUMDFlMHBlQ0dt?=
 =?utf-8?B?cTFMcU1SRU40aXRDaWJpaFRvTDU1NEhvbmtHajNxRTYrUE1aMUVDbnBZODdp?=
 =?utf-8?B?QmlKTEppdS9hOEE2T2tBbm1LOFRLMG9DMEI2UEpFb2h4S3ZEZmNiQVBQSEtn?=
 =?utf-8?B?bDViOUpmeXViRzlnRVYrbzVJa3U2OXdoMExZTVg3Y2xtRXZjY0NEZzdkTjZP?=
 =?utf-8?B?ZTNCVGh4cnNhbWQ2NnF2NXlRa2JFQ3dUMW53cXRyYjlxdmJ0OENjbWJNNGxL?=
 =?utf-8?B?Zk9uaTAyOG9rMDEvNGJRUU15OE5TdHpYZ1kzVlFYVzcra2tVTUI2YVhqTkdh?=
 =?utf-8?B?VEhvbXlaa003S0ppOUhmQ0VEdGIxVmRFdllqanFYemIxREFUeXJtV1M4N1Z0?=
 =?utf-8?B?Q1VGUFBXMzc3dkN2TjFjU3RSUnlYbitHZUdUL3J2d0ZVc2hyTzdwdnNudW1Q?=
 =?utf-8?B?TjhLa0Zibkl2TlJ2Q0hvZnZ2aFZ6TDBUUlVrR0o1bVpHemNoZWdtSzBWUnZx?=
 =?utf-8?B?S0RsYVQxb3laVW1RSHVBVlhNbU9PNFliVGY1cEw5aVNrZXNmSnJUWmN1YUdW?=
 =?utf-8?B?eFZXNDN1ZDdWdzFqRXFMTk9rcDRON084Y1JNY1hNM1d5SzFmZXFqOE5sSENp?=
 =?utf-8?B?NzU1ZUZwV0xVUTVLLytXRysydncydytpZ0xMM0VMalVvckFUZWo0MGxaa1Np?=
 =?utf-8?B?MzhEUTh1MmxrM2d0SVFxQ1lxcmFEeGRsdWxzZFdhSWFST2M4TklzY3k0OW5i?=
 =?utf-8?B?QTkzWjFLZ3pjbG01b3Q2cHVudUhIK21xTVpqZUsrbURneVpsYnFaVTU0b0xF?=
 =?utf-8?B?eHRiWmpqQTNTaUxzSjAwWC9LaVNFaVVFNkQzdUZKbi8zdVAzMzdIdGMzakJ3?=
 =?utf-8?B?KzQrVmtwRWtqMkN3OEdldGNKUEZFTmF0aFo2U1M0ZXdQWWcrdGNjMW1rVHp5?=
 =?utf-8?B?cUEzWmpRQTF3cGUvMURTc01aTW85S2JYMHBEdmM1TEdKUUdoV09DVSsyZHlu?=
 =?utf-8?B?MjNMM3llMFdURWpxdmJST2RXZEZVQkU5Rlp2REFxYzdJZk9VYmJFdG5iT2VS?=
 =?utf-8?B?UHJENEZ1OEVGMkRBY0YzbzNHTytCcDlKaE5CS3pFMkhmRnp6WG1CNTJZTEhM?=
 =?utf-8?B?Q0RFeklLcDZ3TWV3YTlPR2NLU3ZZOStsdnZOK2x1WHh1U3VTbWdoeGtTWHpU?=
 =?utf-8?B?Zy8yOFRQSGZWbngwSis1dW9XNGdOWXE3VnNWa3RDUG8wUnNuRk9QTHlGMGlP?=
 =?utf-8?B?VDA5bUY2czJqSk9jQjQ3ZS9tdEFnL3pBeVAyM1ZYQzZhVFJLbFhzRW9YZWxt?=
 =?utf-8?Q?XuPY=3D?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 21759298-3d35-4405-6304-08d9aa76d679
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 09:36:03.3266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WEPIEwYLWUuZpzmbesIufnYwVrQHAtGHdxEoTg0LcE6aSLmYoF33sXOsNfthjMR7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR02MB6508
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

On 2021-11-15 16:41, Andy Shevchenko wrote:
> Recently ACPI gained the acpi_get_local_address() API which may be used
> instead of home grown i2c_mux_gpio_get_acpi_adr().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c | 43 ++------------------------------
>  1 file changed, 2 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index bac415a52b78..31e6eb1591bb 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -49,45 +49,6 @@ static int i2c_mux_gpio_deselect(struct i2c_mux_core *muxc, u32 chan)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_ACPI
> -
> -static int i2c_mux_gpio_get_acpi_adr(struct device *dev,
> -				     struct fwnode_handle *fwdev,
> -				     unsigned int *adr)
> -
> -{
> -	unsigned long long adr64;
> -	acpi_status status;
> -
> -	status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwdev),
> -				       METHOD_NAME__ADR,
> -				       NULL, &adr64);
> -
> -	if (!ACPI_SUCCESS(status)) {
> -		dev_err(dev, "Cannot get address\n");
> -		return -EINVAL;
> -	}
> -
> -	*adr = adr64;
> -	if (*adr != adr64) {
> -		dev_err(dev, "Address out of range\n");
> -		return -ERANGE;
> -	}

In the conversion, I read it as if we lose this overflow check. Why is that
not a problem?

Cheers,
Peter

> -
> -	return 0;
> -}
> -
> -#else
> -
> -static int i2c_mux_gpio_get_acpi_adr(struct device *dev,
> -				     struct fwnode_handle *fwdev,
> -				     unsigned int *adr)
> -{
> -	return -EINVAL;
> -}
> -
> -#endif
> -
>  static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  				 struct platform_device *pdev)
>  {
> @@ -141,9 +102,9 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  			fwnode_property_read_u32(child, "reg", values + i);
>  
>  		} else if (is_acpi_node(child)) {
> -			rc = i2c_mux_gpio_get_acpi_adr(dev, child, values + i);
> +			rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>  			if (rc)
> -				return rc;
> +				return dev_err_probe(dev, rc, "Cannot get address\n");
>  		}
>  
>  		i++;
>