Message-ID: <d6e2f855-81c0-118f-96f3-f29c2059c8c8@axentia.se>
Date:   Thu, 18 Nov 2021 10:48:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v1 2/3] i2c: mux: gpio: Don't dereference fwnode from
 struct device
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Evan Green <evgreen@chromium.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Peter Korsgaard <peter.korsgaard@barco.com>
References: <20211115154201.46579-1-andriy.shevchenko@linux.intel.com>
 <20211115154201.46579-2-andriy.shevchenko@linux.intel.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20211115154201.46579-2-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wkg2NGE5S3RJSmxFOU93dUlta3VhVGU1MlRGY2lDYklkVGRDZEUvQlNZSG9t?=
 =?utf-8?B?eFlRTkpJbU4xY0hNRzEyR1Fybms5cmFzK2tQVmt5TXZGMkxXYkRwemxFeW5Q?=
 =?utf-8?B?YVpJd01FbEowYkVxczZRSWQ0cmlmN1M4bWRBU1ZFSmE5cVdwS05GblJ3d1Vq?=
 =?utf-8?B?Mmw5UUdnVjRudGg0TkE0RGtmK3BwZTdJYjNKbml1TGdVcUwwTkM4R0NEcmlV?=
 =?utf-8?B?VmtxL2RrUENGSHBsVklwTFY2V3pObk15Kzl3NXJrU0FTajFuRGw0M0s2MWl6?=
 =?utf-8?B?QXZkd3J2M05TeHNpRlhvSGxkRzdQTENrWGxRQ2Q4UTdRTDd1RkZ5aVFRdVgr?=
 =?utf-8?B?d2RZdjFkZndrYjJoUmJ3RUlxdERrZ3haRHhqRlVPS2NYRWJRUkNKbUtVSzkr?=
 =?utf-8?B?bmRHQmhpaEhMOWhFaDB5NHJQSkUxZlBYRTUydXpkRndDME5HbkMvVkE5bUI5?=
 =?utf-8?B?bmNKd05kZXFZbnB0ZERjK2pwOFpWYkxiZG5iYk1iWFlDS3k5U0J6UmpvMXFo?=
 =?utf-8?B?M2oxTXI5Y0hPZHJxMlZLcUZIR1l1WVRzb2lRcmFoR0JiV0E4TVNVTUUzelo5?=
 =?utf-8?B?OGZVbXB3anM1SnJtM1VBMUF3Q0xOcmlqeGR3T3FINFBYVEFEMU9Rd2MzY211?=
 =?utf-8?B?blA3OS9iaWVOZUxkLzZpY1B2UVNwclpMRzZGeVQ4cjY3T3ZrUXQ3U3NoQmlh?=
 =?utf-8?B?VkhOM0pwWjNYTEQzVDNTNHdpY3lxWTNUZE5jWkN1cTdkZ2g0a0MrdEdBR0xR?=
 =?utf-8?B?anRmdTkzeVkvMmJIVWhTRmlPU3N5SHZvTEhQSGxuaWpKQUlmSWp6QmorWG5R?=
 =?utf-8?B?OWFVRHYrenc2T3VQK2xFQy8zR2YwbEVZQm4vbU95ZUltOU1JWjBWK0dhNXFy?=
 =?utf-8?B?YzBqZ0xzaVFnRjFQSjRGZUtKTlhpSHVRQUh3ZUV5RlhMTnpEREZONDRWNEZi?=
 =?utf-8?B?N1d5akRwTDhOL3E2N1pCS2pjTE0wb1hZSk5CbVczTTh0UExWeDZCNVgxWGI3?=
 =?utf-8?B?QUVsQ2xVRi8vWmNGQjlhYVo4dTVuL285YzBEeUNpODJENHpxcmtOUDNFR2Zr?=
 =?utf-8?B?bFNXbDdoN21MZ1ZCTDYrMnhXbkZmYzJtaGxSL3Vab2lqVG9iSzFHSEZpQ21y?=
 =?utf-8?B?eXkxQi8wdzRQbURJUE8vRWI3UTNnSGhrSkZGRXBEMGp2SnNvcWlBY0c0UEhI?=
 =?utf-8?B?V216ZUJ4SUNjeW5YdDZCNjUxaTJrWno4TlJyUS9SVXhiMUdtbVhzTG1qTGJM?=
 =?utf-8?B?UmJrQURpc3BMYkpOcTkwOGh5VzJWRTlwOWplWWhzQitkTkdmd0hSdWJOOUpO?=
 =?utf-8?B?bnU3a2RVd2Z0dXJTK3l0ZmVYVklDVGIvQ200RDB1MXlFOTFmRzhreTBBTTM2?=
 =?utf-8?B?Z0RQYWJvNjU3cWFjeGFYUFpzc0kyZ2Z6RVE0UTNiSG1WaG1WVXdveUxiRThV?=
 =?utf-8?B?SmN4eXFFUk9mbWlGcnYreGNEUktKTG5qMnpJVXArcW5BZFE1UjRibTRMcTls?=
 =?utf-8?B?NnFmTmx3NGJrV1JPdHhLZ20wZnZNUm9kTnBISzFSQXB6NzlOVjF2b0p0MU1E?=
 =?utf-8?B?VlB3VHV5enp4R3lGVmdsL3VtVHA5eXcrdVVNOU53S1NrTUs3SXAwb1ZtbkY2?=
 =?utf-8?B?Y3dSU20rRkFlZXNoY3ZVM1A4Njdmd0xZN1F3eUZkZUM5OWQvc2Q5LzVhNFMx?=
 =?utf-8?B?MHNtRzN6WVY2ZG90QWFaeldYM2lQVVV6WHdCeVBJY055cUtPZXlZd2lJV0ZN?=
 =?utf-8?B?aCtXVUVTbzhjRThkZnU5SWQ5aVFxOFJ2V053eGRwcDNrOHJHSkFpV0lYKzM3?=
 =?utf-8?B?MU9WeWFoN1pHYkpGVXRZcE9sNkpQMGpsNnREWEFhdDVudXFGZmZSVEZWUXRs?=
 =?utf-8?B?UGovYWNRYkxqK3orQjI1Q3pHM2JaT3ZOUkw3VHZNWnVQMDQ5L3MwSTQrbjRs?=
 =?utf-8?B?Y2lJRHJkOWxTQkxxd0dSVFlLaG5Qc3VJYlhGUnpIUHJIZm1oUjFJOERnWVdM?=
 =?utf-8?B?THJLT0xJUzlaUkVuYVVteldjTks5bUx4QS82bDJERkIzaDcyUVF4NEdlb3k4?=
 =?utf-8?B?cmw1UlJ3VDVTYVZUZ2xJRXpHQVdhaklvSHBIa293amJVeGJPYi95SWlBbWh1?=
 =?utf-8?Q?zCp0=3D?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 9998f2a4-5206-4013-c84a-08d9aa788dc3
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 09:48:20.2570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fNLD1VoKN3MCeIHQQjFy7OjXL/Rsjrh+nHJMfdMUmlHMz5U2JV+LeSXL18npZKvv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR02MB3063
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

On 2021-11-15 16:42, Andy Shevchenko wrote:
> We have a special helper to get fwnode out of struct device.
> Moreover, dereferencing it directly prevents the fwnode
> modifications in the future.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 31e6eb1591bb..b09c10f36ddb 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -53,6 +53,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  				 struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> +	struct fwnode_handle *fwnode = dev_fwnode(dev);
>  	struct device_node *np = dev->of_node;

It feels like there is opportunity to get rid of np, but I suppose that can be
done later...

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

>  	struct device_node *adapter_np;
>  	struct i2c_adapter *adapter = NULL;
> @@ -60,7 +61,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  	unsigned *values;
>  	int rc, i = 0;
>  
> -	if (is_of_node(dev->fwnode)) {
> +	if (is_of_node(fwnode)) {
>  		if (!np)
>  			return -ENODEV;
>  
> @@ -72,7 +73,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  		adapter = of_find_i2c_adapter_by_node(adapter_np);
>  		of_node_put(adapter_np);
>  
> -	} else if (is_acpi_node(dev->fwnode)) {
> +	} else if (is_acpi_node(fwnode)) {
>  		/*
>  		 * In ACPI land the mux should be a direct child of the i2c
>  		 * bus it muxes.
> @@ -111,7 +112,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  	}
>  	mux->data.values = values;
>  
> -	if (fwnode_property_read_u32(dev->fwnode, "idle-state", &mux->data.idle))
> +	if (device_property_read_u32(dev, "idle-state", &mux->data.idle))
>  		mux->data.idle = I2C_MUX_GPIO_NO_IDLE;
>  
>  	return 0;
>