Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750822AbXAKR7F (ORCPT ); Thu, 11 Jan 2007 12:59:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751301AbXAKR7F (ORCPT ); Thu, 11 Jan 2007 12:59:05 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:59639 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbXAKR7E (ORCPT ); Thu, 11 Jan 2007 12:59:04 -0500 Date: Thu, 11 Jan 2007 17:58:33 +0000 From: Christoph Hellwig To: Jay Cliburn Cc: Christoph Hellwig , jeff@garzik.org, shemminger@osdl.org, csnook@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver Message-ID: <20070111175833.GA15053@infradead.org> Mail-Followup-To: Christoph Hellwig , Jay Cliburn , jeff@garzik.org, shemminger@osdl.org, csnook@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20070111004137.GC2624@osprey.hogchain.net> <20070111092704.GB3141@infradead.org> <20070111165330.GA6191@osprey.hogchain.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070111165330.GA6191@osprey.hogchain.net> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 19 On Thu, Jan 11, 2007 at 10:53:30AM -0600, Jay Cliburn wrote: > On Thu, Jan 11, 2007 at 09:27:04AM +0000, Christoph Hellwig wrote: > > On Wed, Jan 10, 2007 at 06:41:37PM -0600, Jay Cliburn wrote: > > > +/** > > > + * atl1.h - atl1 main header > > > > Please remove these kind of comments, they get out of date far too soon > > and don't really help anything. (Also everywhere else in the driver) > > Is your concern here with the filename portion of the comment only, or > with the entire comment including the copyright and other material? Only the line I quoted. Copyright statements and similar things are obviously fine :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/