Subject: Re: [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe
 PMU
To:     =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>
CC:     Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        PCI <linux-pci@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <zhangshaokun@hisilicon.com>
References: <20211029093632.4350-1-liuqi115@huawei.com>
 <20211029093632.4350-3-liuqi115@huawei.com>
 <CAC52Y8Zc5oRRBDiZq+zQNGw2CbURN2SRsfW9ek_gw96qDHB1zw@mail.gmail.com>
From:   "liuqi (BA)" <liuqi115@huawei.com>
Message-ID: <acb5a232-dd09-9292-5b24-25e8e29e98e7@huawei.com>
Date:   Thu, 18 Nov 2021 21:10:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <CAC52Y8Zc5oRRBDiZq+zQNGw2CbURN2SRsfW9ek_gw96qDHB1zw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2021/11/18 6:41, Krzysztof Wilczyński wrote:
> Hi Qi,
> 
> Thank you for working on this!  Looks really good!
> 
> Below a few tiny nitpicks that you are more than welcome to ignore, of
> course, as these would have little weight on the final product, so to
> speak.
> 
>> +struct hisi_pcie_pmu {
>> +     struct perf_event *hw_events[HISI_PCIE_MAX_COUNTERS];
>> +     struct hlist_node node;
>> +     struct pci_dev *pdev;
>> +     struct pmu pmu;
>> +     void __iomem *base;
>> +     int irq;
>> +     u32 identifier;
>> +     /* Minimum and maximum bdf of root ports monitored by PMU */
>> +     u16 bdf_min;
>> +     u16 bdf_max;
>> +     int on_cpu;
>> +};
> 
> Would the above "bdf" be the PCI addressing schema?  If so, then we could
> capitalise the acronym to keep it consistent with how it's often referred
> to in the PCI world.
> 
Hi Krzysztof,

got it, will change it to Bdf to keep the consistent, thanks.

> [...]
>> +static int __init hisi_pcie_module_init(void)
>> +{
>> +     int ret;
>> +
>> +     ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_HISI_PCIE_PMU_ONLINE,
>> +                                   "AP_PERF_ARM_HISI_PCIE_PMU_ONLINE",
>> +                                   hisi_pcie_pmu_online_cpu,
>> +                                   hisi_pcie_pmu_offline_cpu);
>> +     if (ret) {
>> +             pr_err("Failed to setup PCIe PMU hotplug, ret = %d.\n", ret);
>> +             return ret;
>> +     }
> 
> The above error message could be made to be a little more aligned in terms
> of format with the other messages, thus it would be as follows:
> 
>    pr_err("Failed to setup PCIe PMU hotplug: %d.\n", ret);
>
> Interestingly, there would be then no need to add the final dot (period) at
> the end here, and that would be true everywhere else.
> 

thanks for your reminder , I'll fix that printout message to keep align.

Thanks,
Qi


> Again, thank you so much for working on this, it's very much appreciated!
> 
> Acked-by: Krzysztof Wilczyński <kw@linux.com>
> 
>          Krzysztof
> .
>