IronPort-SDR: IgVHdGdfN1vVE4ffD2slPPBESiLzb50BsRLXZ1vbwPtJzki5NKZtj7t/btsxz9Vzr4YtG7xR0V
 idpv5knBfdIE61wwX7BPZKOjYs8kWbchVcCcicc51Hnf/GFQaegxYMRCEBAja99a/qP43oPtja
 qurioZdQE2pezYF2HMO5vI6NLb/G/1kfdvll3u2Own4JjJaWta/M6ufhx73uACjj/XeXdxZiRD
 9vhBY2aK4voqp2XgdnHiYg6KhpHwUsCx6cQVTPyjemNrC11mF2deZXNGn7r2IW3r6+DRJAe5tA
 MpCc+0gH9UBXnesaQWjxNElr
Subject: Re: [PATCH] pwm: Use div64_ul instead of do_div
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
CC:     <cgel.zte@gmail.com>, <linux-pwm@vger.kernel.org>,
        <alexandre.belloni@bootlin.com>, Zeal Robot <zealci@zte.com.cn>,
        <linux-kernel@vger.kernel.org>, <ludovic.desroches@microchip.com>,
        <thierry.reding@gmail.com>,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        <lee.jones@linaro.org>, <linux-arm-kernel@lists.infradead.org>
References: <20211117020426.159242-1-deng.changcheng@zte.com.cn>
 <20211117112400.bkscb2pyavonpfsn@pengutronix.de>
 <YZYmZecp8WPkFY2F@shell.armlinux.org.uk>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <a9a62f9d-7227-0421-e36f-44222b79bbe7@microchip.com>
Date:   Thu, 18 Nov 2021 14:19:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YZYmZecp8WPkFY2F@shell.armlinux.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 18/11/2021 at 11:09, Russell King (Oracle) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Nov 17, 2021 at 12:24:00PM +0100, Uwe Kleine-K?nig wrote:
>> Hello,
>>
>> On Wed, Nov 17, 2021 at 02:04:26AM +0000, cgel.zte@gmail.com wrote:
>>> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>>>
>>> do_div() does a 64-by-32 division. If the divisor is unsigned long, using
>>> div64_ul can avoid truncation to 32-bit.
>>
>> After some research I understood your commit log. I'd write:
>>
>>        do_div() does a 64-by-32 division. Here the divsor is an
>>        unsigned long which on some platforms is 64 bit wide. So use
>>        div64_ul instead of do_div to avoid a possible truncation.
>>
>> The priority of this patch seems to be low, as the device seems to exist
>> only on (32bit) arm.
> 
> ... where unsigned long is 32-bit.
> 
> In any case, for this to overflow, we would need to have a clock in
> excess of 2^32-1 Hz, or around 4GHz - and if we had such a situation
> on 32-bit devices, we need to change the type for holding the frequency
> in the clk API, and probably a lot of code in the CCF as well.
> 
> Unless there is a real reason for this change, I would suggest leaving
> the code as is - there is absolutely no point in making these divisions
> more expensive unless there is a real reason.

Thanks for the technical demonstration Russell. With this in mind:
NACK to the patch, sorry Changcheng Deng.

Best regards,
   Nicolas


-- 
Nicolas Ferre