Date:   Thu, 18 Nov 2021 14:33:50 +0100
Message-ID: <s5hy25lio5d.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <alsa-devel@alsa-project.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers
In-Reply-To: <1637219231-406-1-git-send-email-spujar@nvidia.com>
References: <1637219231-406-1-git-send-email-spujar@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 18 Nov 2021 08:06:55 +0100,
Sameer Pujar wrote:
> 
> There are two cleanups in the series:
>  1. Use correct value type for enum controls. This is suggested by
>     Takashi during review of v2.
> 
>  2. This series fixes kcontrol put callback in some of the Tegra drivers
>     which are used on platforms based on Tegra210 and later. The callback
>     is expected to return 1 whenever the HW update is done.
> 
>     This idea is suggested by Jaroslav. Similar suggestion came from
>     Mark during review of series [0] and drivers under this were updated
>     to return 1, but missed to take care of duplicate updates. This series
>     updates all concerned drivers to return proper values and duplicate
>     updates are filtered out.
> 
> I have added 'Suggested-by" tags accordingly.
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/
> 
> Changelog
> =========
>  v2->v3:
>  -------
>    * Add fixes related to wrong value type as suggested by Takashi.
>      Relevant drivers are updated as part of it.
> 
>    * Use separate get/put callbacks for each mixer control. The common
>      part is pushed to separate function wherever applicable, thus
>      removing usage of strstr() calls. The return values are fixed
>      as suggested.
> 
> 
>  v1->v2:
>  -------
>    * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of
>      duplicate updates.
>    * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX
>      and Mixer drivers.
> 
> Sameer Pujar (16):
>   ASoC: tegra: Fix wrong value type in ADMAIF
>   ASoC: tegra: Fix wrong value type in I2S
>   ASoC: tegra: Fix wrong value type in DMIC
>   ASoC: tegra: Fix wrong value type in DSPK
>   ASoC: tegra: Fix wrong value type in SFC
>   ASoC: tegra: Fix wrong value type in MVC
>   ASoC: tegra: Fix kcontrol put callback in ADMAIF
>   ASoC: tegra: Fix kcontrol put callback in I2S
>   ASoC: tegra: Fix kcontrol put callback in DMIC
>   ASoC: tegra: Fix kcontrol put callback in DSPK
>   ASoC: tegra: Fix kcontrol put callback in AHUB
>   ASoC: tegra: Fix kcontrol put callback in MVC
>   ASoC: tegra: Fix kcontrol put callback in SFC
>   ASoC: tegra: Fix kcontrol put callback in AMX
>   ASoC: tegra: Fix kcontrol put callback in ADX
>   ASoC: tegra: Fix kcontrol put callback in Mixer

Through a quick glance, the series looks good to me.  One place could
be more optimized with a regmap helper, but it's a minor issue and can
be updated later, too.

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi