MIME-Version: 1.0
References: <20211110220050.2854-1-jirivanek1@gmail.com>
In-Reply-To: <20211110220050.2854-1-jirivanek1@gmail.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Thu, 18 Nov 2021 15:50:15 +0100
Message-ID: <CAG3jFyvB-Dzd9YDJ7FrAC5avobL7Wfk-91E-DVeYWwfNcQLiLg@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
To:     Jiri Vanek <jirivanek1@gmail.com>,
        Zheng Bin <zhengbin13@huawei.com>,
        Vinay Simha BN <simhavcs@gmail.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

+ Zhen & Vinay

This patch looks good in itself, but I would like to see a tested by
tag. At the very least testing for regression in single-link LVDS but
ideally some third party verification of this patch.

On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>
> Fixed wrong register shift for single/dual link LVDS output.
>
> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> ---
>  drivers/gpu/drm/bridge/tc358775.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> index 2272adcc5b4a..1d6ec1baeff2 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>  }
>
>  #define TC358775_LVCFG_LVDLINK__MASK                         0x00000002
> -#define TC358775_LVCFG_LVDLINK__SHIFT                        0
> +#define TC358775_LVCFG_LVDLINK__SHIFT                        1
>  static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>  {
>         return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> --
> 2.30.2
>