Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09267C433EF for ; Thu, 18 Nov 2021 15:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E604C6126A for ; Thu, 18 Nov 2021 15:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbhKRP2z (ORCPT ); Thu, 18 Nov 2021 10:28:55 -0500 Received: from mail-vk1-f180.google.com ([209.85.221.180]:45579 "EHLO mail-vk1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbhKRP2z (ORCPT ); Thu, 18 Nov 2021 10:28:55 -0500 Received: by mail-vk1-f180.google.com with SMTP id m19so3999009vko.12; Thu, 18 Nov 2021 07:25:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l75YBvaIKIqMqRd0fPmOyxtiZBsumc8q9gz1NkIt1Os=; b=zmBlb8RiIvXVZs0/HRSajIyAL9eQ0lqYKFPYwoGLjOaVp/X9QAI99bQHP9rkW8Nonw fcl1xcvT5M0a7sn8sVtLaQ05g9q2FF8b05yl0xGIKtVfFngdDeQdL9GdPG4mIGq+M4+m 6XREFcqV91Tz+Okxfw5krRP1zVYOSCzdjfiD9xcJZoFtkKfRfe2YvtqUCgfpc5sriAGI RdUhk962sQ9SSXKHg/krx6M7X59aFY6mCfITQJVazdiyG+J408vLT+TP6TI0Pt/FeMFC ML9RAJnkoOXZqP/cMrgdCW36cfNCHuKTNx9SUQ75BxZ956ioFxFKqPwvwl+IGs9kvfh1 3vcQ== X-Gm-Message-State: AOAM532VfHTHyGUGM2++e8JhB6VRJDY8WvAnN4NAfKjEZtgFNS8nsYmQ OjgPhAL4Edrb+VnRqW4PZBIwUJaippNzJQ== X-Google-Smtp-Source: ABdhPJwPINizTvpshG6X52QT8E8P79GrAmIz20sbfN05UjqYivYKBpMiDkqYDdfLytK3SGlvQ6nanA== X-Received: by 2002:a1f:f24f:: with SMTP id q76mr104864791vkh.11.1637249153981; Thu, 18 Nov 2021 07:25:53 -0800 (PST) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com. [209.85.222.51]) by smtp.gmail.com with ESMTPSA id f21sm45253vke.39.2021.11.18.07.25.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Nov 2021 07:25:53 -0800 (PST) Received: by mail-ua1-f51.google.com with SMTP id y5so14436512ual.7; Thu, 18 Nov 2021 07:25:53 -0800 (PST) X-Received: by 2002:a67:af0a:: with SMTP id v10mr82716792vsl.35.1637249153248; Thu, 18 Nov 2021 07:25:53 -0800 (PST) MIME-Version: 1.0 References: <20211117115101.28281-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211117115101.28281-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20211117115101.28281-2-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 18 Nov 2021 16:25:41 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] clk: renesas: rzg2l: Check return value of pm_genpd_init() To: Lad Prabhakar Cc: Michael Turquette , Stephen Boyd , Jiri Kosina , Linux-Renesas , linux-clk , Linux Kernel Mailing List , Prabhakar , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2021 at 12:51 PM Lad Prabhakar wrote: > Make sure we check the return value of pm_genpd_init() which might fail. > Also add a devres action to remove the power-domain in-case the probe > callback fails further down in the code flow. > > Fixes: ef3c613ccd68a ("clk: renesas: Add CPG core wrapper for RZ/G2L SoC") > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds