Message-ID: <e311fa3e7a187ca32920534310b0a0cbd3b6526f.camel@svanheule.net>
Subject: Re: [PATCH v3 2/2] watchdog: Add Realtek Otto watchdog timer
From:   Sander Vanheule <sander@svanheule.net>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org
Date:   Thu, 18 Nov 2021 18:15:41 +0100
In-Reply-To: <62050743-bc11-cc21-c6ae-0be9d7b5633c@roeck-us.net>
References: <cover.1636018117.git.sander@svanheule.net>
         <2dbf0c6e0eebf523008c15794434d2d1a9b1260e.1636018117.git.sander@svanheule.net>
         <20211117052054.GA215087@roeck-us.net>
         <787cfd2ab58fb7f1d841f0ced261213f9c2050ae.camel@svanheule.net>
         <62050743-bc11-cc21-c6ae-0be9d7b5633c@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Guenter,

On Wed, 2021-11-17 at 04:42 -0800, Guenter Roeck wrote:
> On 11/16/21 11:13 PM, Sander Vanheule wrote:
> > Hi Guenter,
> > 
> > On Tue, 2021-11-16 at 21:20 -0800, Guenter Roeck wrote:
> > > On Thu, Nov 04, 2021 at 10:32:13AM +0100, Sander Vanheule wrote:
> > > > Realtek MIPS SoCs (platform name Otto) have a watchdog timer with
> > > > pretimeout notifitication support. The WDT can (partially) hard reset,
> > > > or soft reset the SoC.
> > > > 
> > > > This driver implements all features as described in the devicetree
> > > > binding, except the phase2 interrupt, and also functions as a restart
> > > > handler. The cpu reset mode is considered to be a "warm" restart, since
> > > > this mode does not reset all peripherals. Being an embedded system
> > > > though, the "cpu" and "software" modes will still cause the bootloader
> > > > to run on restart.
> > > > 
> > > > It is not known how a forced system reset can be disabled on the
> > > > supported platforms. This means that the phase2 interrupt will only fire
> > > > at the same time as reset, so implementing phase2 is of little use.
> > > > 
> > > > Signed-off-by: Sander Vanheule <sander@svanheule.net>
> > > 
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > Thank you for the review! In the meantime, I was preparing a v4 of this series with some
> > small changes (see inline below). Could you let me know if I can keep your Reviewed-by
> > with those changes?
> > 
> 
> I think it would be better to re-review it.

I sent out the v4 a bit later than expected, because I hit a regression for the irqchip on
this platform:
https://lore.kernel.org/all/bbe5506a2458b2d6049bd22a5fda77ae6175ddec.camel@svanheule.net/


Best,
Sander