From:   Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
To:     netdev@vger.kernel.org, vladimir.oltean@nxp.com
Cc:     ioana.ciornei@nxp.com, mickeyr@marvell.com,
        serhiy.pshyk@plvision.eu, taras.chornyi@plvision.eu,
        Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH net v2] net: marvell: prestera: fix brige port operation
Date:   Thu, 18 Nov 2021 21:48:03 +0200
Message-Id: <1637264883-24561-1-git-send-email-volodymyr.mytnyk@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vAICLmZON1cxApYWmBuI8MtXDRvXarUG5/VpO481F3ACpxAs+Hfui9IrGUVw?=
 =?us-ascii?Q?cM8eZoPDLhiQDjjffDdmywuAvoo0P5VrTn4/qHKgwKOVJbYx8uB+OCYudP+N?=
 =?us-ascii?Q?yr+8uOjD/axBLcJNsAjI+/Yx4ya3T199WHpqRIm4ai05Jsd+uTt56b9Ktvwd?=
 =?us-ascii?Q?SWvZG4H/NPLcH73hQFYEugw1u2vZl+JNo7N6EjBdcpa5nfDGbJqGL8T64wAj?=
 =?us-ascii?Q?M3WNdeKO+QMATgTVuOgyBNJ3UQ9EEZHyMsB8OUmtHLdVWuckVAyF+v8wFQ7l?=
 =?us-ascii?Q?xTkmZgCTxdR4Ds38iBhJwG0ijIcHWPDm+rxDiN2W4ZqHIYEzxuTL5nmz7FLK?=
 =?us-ascii?Q?0On/6bIBomWhOd7dJj4xNfcXV9UKHdpaQRm2fjLfam1RopwkH03zO/EW2srI?=
 =?us-ascii?Q?30UNfqLzanioLarWh7jatkf48hp2OqR+sqevBegJmJrEwpamUmCbsZnenQjl?=
 =?us-ascii?Q?PISeInvNUjZUSFYTPAn35sIHnM8PZOjSYVBg+9Gtq0QXcMUcMEeesbVb3moF?=
 =?us-ascii?Q?aGq8+1AH4RdJHdluQXrsAHolEKMAg946w4TaYM27Z6lWmJSqywBOfaWSVOEF?=
 =?us-ascii?Q?YlcMadHNjFxUnzZnOvjSAv9JR4L/ESRJ2/3evC/FQANINy63KelCm8IH05q6?=
 =?us-ascii?Q?SCyPfEUN9DWKQf4cQyFAYEJzUJJZ6zepcDWB3zm/6nUfo9dAakobW1ufG9J3?=
 =?us-ascii?Q?WASAh0rxfXWbmGCp3k51tnaKpYPATsyvrPLd3gD6rvpLxV2nZ9juhoWZZXOe?=
 =?us-ascii?Q?gMI1Oq62JFzLICk/2/HRUx7peP5IXioXkRzn23t0nK3SbVE9u6opI2yqfMy+?=
 =?us-ascii?Q?GuL1xNVMySSs7Hm8J2YKuVl8bosyvBI0ULRvJ7rXpiI7WQB6N5ZChUHfWZ89?=
 =?us-ascii?Q?gT0wbvesKCRCmmqNZ9XTNFlYF9VabUWlTwx6fOuT2lCDMJcwt5i99mHjDGFF?=
 =?us-ascii?Q?yopMmyE0B9vMXKE7I21t59IXffj/8t4R4LHqcI3l42wUVkV8UnLaC1p5qbnj?=
 =?us-ascii?Q?aqRl6lRmdspASD9cscappvNNaevsbNIUoX1WePZ/4MAU6UpDEbr1DyySinuc?=
 =?us-ascii?Q?6YayLPhBH29TfTFx+qq6P18dmiZqup9c3m/b991UERZW6iOkQZ6sieIlbGcj?=
 =?us-ascii?Q?orLZdLS/PjwixPdg229Jv7fEDFN+MAxgu/yDZRqtm2YvDz7UyKVl6OdsOFV4?=
 =?us-ascii?Q?8SpnXUKo9lkFhTGdKCucduRwpvBvmS4g8XSsmJYT/CLsjHH6567CrXPUJ9K1?=
 =?us-ascii?Q?XZ+Gtt6jlL9Zo4YXc6yCusxLK/VOfRooqS+Bk8fQCJt24Rn3eNE3NBDCyS9q?=
 =?us-ascii?Q?yB31EFh8TPN9B83oYBsPE7SJuXlfl041zA1YhwbwC68x+b42vrWdDXddRYci?=
 =?us-ascii?Q?+LlTI7dbphPXZ5vfo2cSr3BiVs7wjnV01AdOC17OIvNiYBYtP3XicxIDKACk?=
 =?us-ascii?Q?ZRX+9CMMQ++agtIvDPu+PWIBcNqwlvVPR/NBsBpNfM+Y3XGR+Zms/0folmgq?=
 =?us-ascii?Q?OOI0HiWlH67Cpy/GXlU3E365zn16f/dxDMIS3keY8wo1jwFtJl1x1x8z9P0q?=
 =?us-ascii?Q?5SaiyByE6uxbjgGZVZPj/jONQmTAdujchUA0+koUHTzIxVd/x246rAO57KOh?=
 =?us-ascii?Q?6gWFYH9g3LoXjjstITFyj/4EpfcP4lSKjGOGE9YkQIkU23SdNlQxQw/Oiu8l?=
 =?us-ascii?Q?Va8Gzw=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d753de5-da30-41ed-da3d-08d9aacc7dda
X-MS-Exchange-CrossTenant-AuthSource: VI1P190MB0734.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 19:49:11.2664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aZCC/8u6VFNMUPBw4DUKxQ6iaqmS85ymRJDZbITc6f7EvbGuG+4ApDTAFhubtQCG6bnr69NAJr0ivT23ycNGVIO/FILiKChhS6SZFHbllCs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1P190MB0432
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Volodymyr Mytnyk <vmytnyk@marvell.com>

Return NOTIFY_DONE (dont't care) for switchdev notifications
that prestera driver don't know how to handle them.

With introduction of SWITCHDEV_BRPORT_[UN]OFFLOADED switchdev
events, the driver rejects adding swport to bridge operation
which is handled by prestera_bridge_port_join() func. The root
cause of this is that prestera driver returns error (EOPNOTSUPP)
in prestera_switchdev_blk_event() handler for unknown swdev
events. This causes switchdev_bridge_port_offload() to fail
when adding port to bridge in prestera_bridge_port_join().

Fixes: 957e2235e526 ("net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge")
Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>
---

Changes in V2:
 - Split changes into two independent commits:
   - fix prestera_switchdev_blk_event() handler (THIS PATCH)
   - fix error path handling in prestera_bridge_port_join() (NEW)
 - Updated fix tags in both patches according to review comments
 - Fix commit messages in both patches

 drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
index 3ce6ccd0f539..79f2fca0d412 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
@@ -1124,7 +1124,7 @@ static int prestera_switchdev_blk_event(struct notifier_block *unused,
 						     prestera_port_obj_attr_set);
 		break;
 	default:
-		err = -EOPNOTSUPP;
+		return NOTIFY_DONE;
 	}
 
 	return notifier_from_errno(err);
-- 
2.7.4