Date:   Thu, 18 Nov 2021 14:30:33 -0600
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Dang Huynh <danct12@riseup.net>
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Alexey Min <alexey.min@gmail.com>,
        Caleb Connolly <caleb@connolly.tech>,
        Martin Botka <martin.botka@somainline.org>,
        Konrad Dybcio <konradybcio@gmail.com>
Subject: Re: [PATCH v3 0/8] Improve support for Xiaomi Redmi Note 7
Message-ID: <YZa36ZACKVShtNtM@builder.lan>
References: <20211111031635.3839947-1-danct12@riseup.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211111031635.3839947-1-danct12@riseup.net>
Precedence: bulk

On Wed 10 Nov 21:16 CST 2021, Dang Huynh wrote:

> This series expand the Redmi Note 7 device port to support:
>  + Regulators
>  + Volume keys
>  + eMMC and SD card slot
>  + Framebuffer display
>  + USB
> 

Thanks for the patches Dang, I think they look good and would like to
merge them.

Could you please submit an updated version with the one gpio.h inclusion
pointed out by Konrad moved and fix up the Reviewed-by pointed out my
Martin?

Thanks,
Bjorn

> Changes in v2:
>  - Dropped linux,input-type from volume up as 1 is set by default.
>  - Dropped gpio-key,wakeup as it's a legacy property name and is
> not relevant for a volume button.
>  - Rename label cont_splash_mem to framebuffer_mem and change node
> name to memory.
> 
> Changes in v3:
>  - Add voltage range for vph_pwr
>  - Move RESIN to PM660 and make PON keys disabled by default 
>  - Addressed review comments from Konrad
>  - Make Alexey Min the author of the USB patch as he came up with
> the patch first on downstream. 
> 
> Alexey Min (1):
>   arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB
> 
> Dang Huynh (7):
>   arm64: dts: qcom: sdm630: Assign numbers to eMMC and SD
>   arm64: dts: qcom: sdm630-pm660: Move RESIN to pm660 dtsi
>   arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators
>   arm64: dts: qcom: sdm660-xiaomi-lavender: Add PWRKEY and RESIN
>   arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
>   arm64: dts: qcom: sdm660-xiaomi-lavender: Add eMMC and SD
>   arm64: dts: qcom: sdm660-xiaomi-lavender: Enable Simple Framebuffer
> 
>  arch/arm64/boot/dts/qcom/pm660.dtsi           |  12 +-
>  .../dts/qcom/sdm630-sony-xperia-nile.dtsi     |  16 +-
>  arch/arm64/boot/dts/qcom/sdm630.dtsi          |   5 +
>  .../boot/dts/qcom/sdm660-xiaomi-lavender.dts  | 383 ++++++++++++++++++
>  4 files changed, 407 insertions(+), 9 deletions(-)
> 
> -- 
> 2.33.1
>