Subject: Re: [PATCH v2 11/13] perf tools: improve IBS error handling
To:     Stephane Eranian <eranian@google.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com,
        mpe@ellerman.id.au, maddy@linux.ibm.com
References: <20211111084415.663951-1-eranian@google.com>
 <20211111084415.663951-12-eranian@google.com>
 <689f7b71-32b8-ba0e-22ff-c2248662b1e1@amd.com>
 <CABPqkBQNpFUGm0Eu3KtPwex1r7G5C0yp-F+fsjiS+2KJ0uuRqQ@mail.gmail.com>
From:   Kim Phillips <kim.phillips@amd.com>
Organization: AMD
Message-ID: <659eb6eb-3a46-f9b4-730b-026c28a50b31@amd.com>
Date:   Thu, 18 Nov 2021 15:02:55 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <CABPqkBQNpFUGm0Eu3KtPwex1r7G5C0yp-F+fsjiS+2KJ0uuRqQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0JFNGpkTWFDbnBDWGZsdUFlblVlaTVFYWdWQjJFUzVnUnJKeHFuSWh1NDNm?=
 =?utf-8?B?ME1LZ2wyQ0hmcy9yaGhnWEhMdklqS0dGMWo0TGpsVEQ2SnZuTWZOWThWYjVs?=
 =?utf-8?B?SDExaVVUNHdYVEI4ckRYcUVsc0pub2pMODJCZHRkcXdxYjlya0tRWnRHcnRZ?=
 =?utf-8?B?SEx0aTZhQXFlV2VHYjV4OGIxeWZzd2lnbEwwZElWc2pqS3FRM1R2eDROVnhn?=
 =?utf-8?B?MTZjQ3QyQ0dhVlZDMkNyVXEzREg2cWN2cUdCMmhkZU0wOW9WNHkwM1U5SEpv?=
 =?utf-8?B?ZHUxTlJyYXdEY2RrK0V5NTBFa093ZGhaRFFSMnhTQTFaOXJ3eDBnSWpLQXYx?=
 =?utf-8?B?SXRBbkhkVCtzdUpHdmZodGpxS0VLbVBXcGx1cHBtVzZtTithaWtyaWd0NHRr?=
 =?utf-8?B?dGVNeGFTRGFoS2crS0FxbzJ1VFo5cDIzc3c0dWhnci9Nbm5xUHlZN0Y1VFo1?=
 =?utf-8?B?dkUxRVl6ejJYSlJkQ2M1em1EUTdRZUYxVnBMdHJWMkh4bVU2TnhLYTdvK3Zj?=
 =?utf-8?B?ZGE2cEJuZjlhcTlnTlJFZ2xoS0habVhnYmFWL1gvY1FkUlJmRHhZRmd2eG5y?=
 =?utf-8?B?UHhsbzlPWGh1cVg3NTFsMVlSeGxOcGgxYXh5a2dOZzR5WkNHdnJRT051c1FN?=
 =?utf-8?B?dzJRdEVSUTAxZG5EY0VpbDF2aXNaeS9Vekozdmh4VTUzNmlaZlFERit3SWFD?=
 =?utf-8?B?WWc3R1BrSko2SFpwdG1oS1dRa09obDAwWFAvTEZoV0Npd3ZiK3RjY1lmTDd6?=
 =?utf-8?B?ZmVwUHpFVW5Vbm5PQTN1RGRmendIZ2JVSVRjem96SFRCL29xNU1SaEdVVFlW?=
 =?utf-8?B?YmU3ZTBMaXl3Sm5LSFlxRksyRWoxb0t5bC9xNUlmRWtTZmZxNTNxbXlDM1VF?=
 =?utf-8?B?L2RNRVh2dmM5c2tZTVVaT2ZFczVxdlhrRWJSNkNRWTJFWWx1NDZlQ3pwMUh4?=
 =?utf-8?B?SXJ4akJwdG9Jb2wvckMvREo3c0NjbmZKck1aZ1Q3QmR2WitBYXdLMzVaemNL?=
 =?utf-8?B?NzZydGV4bWJQaUZnY0pyL0VyTmh0b0xZS3JZOHRLbksxaHdxQ1Z5UmEzckhS?=
 =?utf-8?B?NEhQazU2M2lwb1U0WFE2bXF5RlB4ZVRTS0hUNjZLakZNY3dvUjU4UGdOOHNj?=
 =?utf-8?B?WFNKOEk2MVpsdlNuMzcyZFNsMWtUY3ZGM2ZTaVkvdXFrcUY2R0NweU95S29v?=
 =?utf-8?B?M3ZIM2RQSHY5R0FHUStwN21XSGlOT01KNkp3TWwxRHcvek84cmEwd2RUbi9L?=
 =?utf-8?B?N0VjN0FCNGhjRTNCZ0ZYbDBvMzRkcWwrYWg1bmdoY3MzbFZHbXUxeHlIQUxR?=
 =?utf-8?B?aGpBbjl5MXJMekZ1TitDUTRQQkNSMW10Z2R1YjVNbGN2MnZDYlYzdlF0QWpZ?=
 =?utf-8?B?bmJyRnhVNzlEcGpvcWFVOHFUOVM1VE53NllpRytGRHdnR29NSi9VSHpnZDhQ?=
 =?utf-8?B?eTY0R09hQkZEWHpQWEl0VVRhVFYvRXE4ODcyZEZ1RDFxS3VHN08ra09Mc1Zy?=
 =?utf-8?B?bmJsVk15dXpNNUYxNm1uWTZUTFBqTUYrWGVseXhHdGZSdURRZlY3MmZDMGVx?=
 =?utf-8?B?NVZJbUpuUFppNTZWMUxndDY5amlKcS84VXNMQ1YyKzBOdm1ibGxYYzM2R2hF?=
 =?utf-8?B?c284cjltZVB4ZkloSkxJRmZMYmpKRmFScUFtenppSnJPdCtkR09NNGZleUpW?=
 =?utf-8?B?YXlGZW5VNlZzWGVxVUhteWgrRU9WWXBIRDR1eEdzeS9IYjRCS0NHd3Z6SEtC?=
 =?utf-8?B?YlRZSFk2WTljOWFwRlZBQkdVQWhaSGRqaTZTMjZCQlNiR3FuVEVML1Myd3dl?=
 =?utf-8?B?aytncHMvL1hkTEFMQTFmMVFvY3pmTUE0OXk5dnJqMlBaV052SU90VTVDY0NX?=
 =?utf-8?B?TENScjU5MWV1cmNJNUNHRXkxVnNHZ0dybVREMUNta25JdU1hYW1NbGtqUlNq?=
 =?utf-8?B?ZkZqWWw3dk9jWUJEbVQ0RURvNlRINzRjbmdYbUdOeHNreExvRWZ0U0gvUWNW?=
 =?utf-8?B?YWFLRHd5UHVFSE5aalU1R0F4c1RWRVdlbGp1bnZxeHA2WHAzeHZVNjd3bjIr?=
 =?utf-8?B?SUVlYXF0SSt2OVk3SkliTnZKSk5YQlYxL0pmeDJwd215M2V5aitVVjdrN0gy?=
 =?utf-8?B?ZVM0bFBaYitsYnQ4MWVDOTBBTlJMbEwxM1lyRWtDWkJqN0Q4NHFtTHZUZk5B?=
 =?utf-8?B?SG0wRm95ODVwR3FRdE8ydTdGVlIvdkh4bms5SnhqTGhwSkVNbWZScDdyOG5O?=
 =?utf-8?Q?oV0wstb3qmhRcLmK94zV/bGeTPZl+a5xGMROsvLT3g=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0092f980-7ae0-44ce-50da-08d9aad6ccd2
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3505.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 21:02:58.8033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PG4RcHvrSCDoQMUZk1FooRBh9R/ywZCWQt3u9LIqywcz1VlC40vZD76e15C257LnA0L5TqILcFu6r0zeohMDFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3043
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/17/21 3:15 AM, Stephane Eranian wrote:
> Kim,
> 
> On Tue, Nov 16, 2021 at 8:46 AM Kim Phillips <kim.phillips@amd.com> wrote:
>>
>> On 11/11/21 2:44 AM, Stephane Eranian wrote:
>>> From: Kim Phillips <kim.phillips@amd.com>
>>>
>>> This patch improves the error message returned on failed perf_event_open() on
>>> AMD when using IBS.
>>>
>>> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
>>> ---
>>
>> Hi, AFAICT this v2 == v1, i.e., this patch doesn't address the comments
>> raised in v1:
>>
>> https://lore.kernel.org/lkml/aa40b532-0e95-76c0-6c9c-a91d45bf3468@amd.com/
>>
>> Arnaldo, orthogonal to this series, it'd be great if you could apply
>> these two patches:
>>
>> https://lore.kernel.org/lkml/20211004214114.188477-1-kim.phillips@amd.com/T/#mc4c9c582e3816ab31af6d0187e6803de1a98ac84
>>
> I don't understand why this patch is related to the IBS error
> handling. Patch 11/13 does not modify the evsel__env() function.

Without it, after applying patch 2/2 of that series and executing
the commands in 2/2's description will cause perf to sigsegv.

> I have included your change in the new version of the patch.
> Thanks.

You mean this one?:

>> Then, Stephane, you could drop this patch and in your next
>> version, patch 12/13 of this series would be replaced with
>> what's at the end of this email:
>>
>> https://lore.kernel.org/lkml/20211004214114.188477-1-kim.phillips@amd.com/T/#m885ead1f280445357c91cce53c01217913bd017b

If so, great, but patch 1/2 in the two-series set mentioned above
will need to be carried along with this series, unless acme
applies those two directly.

Thanks,

Kim