From:   Nick Terrell <terrelln@fb.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Parisc List <linux-parisc@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Geert Uytterhoeven" <geert@linux-m68k.org>,
        Helge Deller <deller@gmx.de>
Subject: [GIT PULL] zstd fixes for v5.16-rc1
Thread-Topic: [GIT PULL] zstd fixes for v5.16-rc1
Thread-Index: AQHX3MJohLd7tvU2E0SoSeZx2RSNQg==
Date:   Thu, 18 Nov 2021 21:22:35 +0000
Message-ID: <1F7E17E1-9B51-4D21-B7FB-9BD3BE4A199A@fb.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wwCDjrAsalPu76qEeKdLx1jemVWZc7QCFwnAtumRBu/qK7uPdgTTxDIIYhdZ?=
 =?us-ascii?Q?U8VIs2R5vLFBKaMVkQaRCLgC7/7cg7HLO/T9lML7hNLJ22EsJLIzm2hqTZfO?=
 =?us-ascii?Q?UnjkOCKuSrDinlk8nzvZnmTOzfwWeM3bMBu+y0dZhGk868iuMgZANG5a8/Jp?=
 =?us-ascii?Q?y3WWHfsF7KiViKW+tTl8xGV+HxZeAISFqEoDUDpUm7Phlq9cdxDaHFNiIVRT?=
 =?us-ascii?Q?BZ+AMVCmvYQi2XCsqjNFhkrAdM6IR9XbUBmx70XXKWvysk5qQEjDxZqze3R1?=
 =?us-ascii?Q?W96DC0CHjlTvXyoTqIGAMWVpuiYBPYymJVZN3VTXm9DQrdjYAcnQ+xq9T0iK?=
 =?us-ascii?Q?sVLgA4RLc0cQIhOFeLmjC338OLuHPGvuc4jwL+GeB+unNId4rSTvi9ixBf1W?=
 =?us-ascii?Q?rUB+6upBKqgB1SjWJVwHs2b6bxEI2PcXE8yUq2Kc6mPnJgaUU672DT6g+waX?=
 =?us-ascii?Q?HA7RxIOTYdWJ4EYYZwNXszfnFHO3G6qUzlnndWrF6ZOWnguF3WuIG9VsUw9E?=
 =?us-ascii?Q?m3Zncrjlnl1xQKq6Xz9aKrVlxbVogDgOS0mltJCoHJVDjKNpTn3cI/6yywKz?=
 =?us-ascii?Q?t8Z+JvYTPAcFMcMVK6oNS1y0Vk+aya+WdEV9HvD7ykEObHPpAPbdJXlA8AWO?=
 =?us-ascii?Q?A4Bhq81Kz0Ki5rBKCFxzUa05oQS8EFm35Rldp3/XngH7k5LyP0O3c+wrrIg9?=
 =?us-ascii?Q?/EHYtIAWNYv2kaANSFDseXA9DZ+ZFyHoMYVsy9wv/hkmmZ17ROaPRoeij9XU?=
 =?us-ascii?Q?Bv48wmAhYtkELMtoMnxLqd+AvYnzgB0xQHNNRV6Ebsic02O6f6ip4vBgfH06?=
 =?us-ascii?Q?Z/oDd/mmRTPD6Gi1wm99HUOtCOw5OW0PRve9T6eaWhLEn3Zkc3aPW5ELNTJA?=
 =?us-ascii?Q?Jwg3ZqDbo+KSO6tUdqovrm8RbXNgU0DHO/NN/k28xxDDRb8R4o33TFpOV19T?=
 =?us-ascii?Q?bH2h/+DOww1Y7pYTgNgxiBTJ5x3wJMCwmoTMurcheND5RruQtB0eV3386HYh?=
 =?us-ascii?Q?Z8PIv/j3Iyaqt2ba1CAwn9UqOHiGmhkaE6++gO/VtKkBx/EPQ7EfMiqgxgpY?=
 =?us-ascii?Q?RyZd/ILMqV8mBErtgTmfDY1h/l0b039BHs/HJjdVhErdhVoLfc+18fVOGibh?=
 =?us-ascii?Q?v58CMTTtpcc8NYhhxSua5lj09qwUcuC08PA9j1lPPCLo1IiwyKnPz6OSFs+m?=
 =?us-ascii?Q?jK4RKHBpi/4Nh6Gbpth4J2XmoGg6ZiZqd/Vlqf8Zn4GfL1Abo3NjKmwdY73K?=
 =?us-ascii?Q?duETagV0t7P27K+EIWinRcssom+VhumHK4nZpO2ApcB0ljBkHnq4RbfYr6Gj?=
 =?us-ascii?Q?q/ioBOmiR626fUXSUVhrims8JV5N/WTOTU9JP87e8cJLDyH+XwV7/HXPLEZ1?=
 =?us-ascii?Q?pafTZzxg6i5trJhobMBH4q4++b/BIisRSaLRxElHLKvLWKIT4p2RUZudAlZv?=
 =?us-ascii?Q?ZdA/Vu4Tbt8ZlR1n2ZdWiC1VvdMpWNIAQbYwQY0rYWDglSWbqF+/c94oHvAz?=
 =?us-ascii?Q?FiDj1MqmNHg/TNXKtOIPmTkD3wdcfmhKyGWfkfpqeOpx6fO3BYOBv+2mPEKx?=
 =?us-ascii?Q?GpwAN2GfCiaqKCM8cEPBU9NfVu3MJWqsNRSTfz/UKBCDpftoqhEjyFaZEROt?=
 =?us-ascii?Q?rg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <046EBE6D33BDB74685D2B59F23BE9519@namprd15.prod.outlook.com>
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3667.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f0a77ee-b4e1-44e6-86dd-08d9aad98a95
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2021 21:22:35.7916
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e7cU7In9uR47D0NTOKSBHWfck4JnW/cP4KzMOYR1zyY451roaX1xv8TOUjXnDcbI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4390
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: CRirX0OoM_5R9l-dWxVQkAnmDuu9ftk9
X-Proofpoint-ORIG-GUID: CRirX0OoM_5R9l-dWxVQkAnmDuu9ftk9
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-18_12,2021-11-17_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0
 spamscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 phishscore=0
 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1015
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111180111
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Linus,

The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:

  Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)

are available in the Git repository at:

  git://github.com/terrelln/linux.git tags/zstd-for-linus-5.16-rc1

for you to fetch changes up to 7416cdc9b9c10968c57b1f73be5d48b3ecdaf3c8:

  lib: zstd: Don't add -O3 to cflags (2021-11-18 13:16:22 -0800)

Best,
Nick Terrell

----------------------------------------------------------------
zstd fixes for v5.16-rc1

Fix stack usage on parisc & improve code size bloat

This PR contains 3 commits:

1. Fixes a minor unused variable warning reported by Kernel test robot [0].
2. Improves the reported code bloat (-88KB / 374KB) [1] by outlining
   some functions that are unlikely to be used in performance sensitive
   workloads.
3. Fixes the reported excess stack usage on parisc [2] by removing -O3
   from zstd's compilation flags. -O3 triggered bugs in the hppa-linux-gnu
   gcc-8 compiler. -O2 performance is acceptable: neutral compression,
   about -1% decompression speed. We also reduce code bloat
   (-105KB / 374KB).

After this commit our code bloat is cut from 374KB to 105KB with gcc-11.
If we wanted to cut the remaining 105KB we'd likely have to trade
signicant performance, so I want to say that this is enough for now.

We should be able to get further gains without sacrificing speed, but
that will take some significant optimization effort, and isn't suitable
for a quick fix. I've opened an upstream issue [3] to track the code size,
and try to avoid future regressions, and improve it in the long term.

[0] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/
[1] https://lkml.org/lkml/2021/11/15/710
[2] https://lkml.org/lkml/2021/11/14/189
[3] https://github.com/facebook/zstd/issues/2867

Link: https://lore.kernel.org/r/20211117014949.1169186-1-nickrterrell@gmail.com/
Link: https://lore.kernel.org/r/20211117201459.1194876-1-nickrterrell@gmail.com/

Signed-off-by: Nick Terrell <terrelln@fb.com>

----------------------------------------------------------------
Nick Terrell (3):
      lib: zstd: Fix unused variable warning
      lib: zstd: Don't inline functions in zstd_opt.c
      lib: zstd: Don't add -O3 to cflags

 lib/zstd/Makefile                            |  2 --
 lib/zstd/common/compiler.h                   |  7 +++++++
 lib/zstd/compress/zstd_compress_superblock.c |  2 ++
 lib/zstd/compress/zstd_opt.c                 | 12 ++++++++++++
 4 files changed, 21 insertions(+), 2 deletions(-)