Subject: Re: [PATCH 2/2] perf tools: Improve IBS error handling
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@redhat.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Ian Rogers <irogers@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Robert Richter <robert.richter@amd.com>,
        Stephane Eranian <eranian@google.com>
References: <20211004214114.188477-1-kim.phillips@amd.com>
 <20211004214114.188477-2-kim.phillips@amd.com> <YV8uQVnMnnMd1Led@krava>
 <8a8583dc-5a5d-f107-8ef0-6be96e2f9095@amd.com>
From:   Kim Phillips <kim.phillips@amd.com>
Organization: AMD
Message-ID: <073f5ae0-0d1d-bbeb-acc6-a10ba2376908@amd.com>
Date:   Thu, 18 Nov 2021 16:45:28 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <8a8583dc-5a5d-f107-8ef0-6be96e2f9095@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1IxTUdNUVZXL2ZPNW9wV1RTbXVZNFJnMSs1Yk1MakIwYnQ4eTZnOWkrbVEw?=
 =?utf-8?B?TWhDaEdBL3ppRlpXamM2eVBsQWEwem1OdzNDaGtNcGtpakdpREsxS25PdXov?=
 =?utf-8?B?TTJqRXVibGFwaFVYTU5jbWh4VEpzcDRGL0JESjdESEJlTEsrSXF6dTFBR1Fq?=
 =?utf-8?B?RndWWERxTGd4OGN2RWlkNWMzbFV2amNwcVRFTW1LeXhzRUtrYUg5Um1YcENk?=
 =?utf-8?B?T3R5NFlxSURWMks5NnZOYm1ianE1dXlScVJyRXM3M3ltbytjS0FWTXJmbjJQ?=
 =?utf-8?B?V2diaUorOVZnd3p4akJBemJhRkIyT1hvcVAxNzlzTUowRzNyYlUvZUpSaW0z?=
 =?utf-8?B?YzUzTGlMR2luSWdMZUlyRzVSd01HWHJHKzFYQjF2bGhrUno2MDE1ZldmRnVB?=
 =?utf-8?B?aXZQMjNrbGhzaXB3Rm8zM0JWb1N1bmtPS0xZV2ZpNFJ3SDFjTENjZC95QVNp?=
 =?utf-8?B?OWs0ZzZJeE5IcXpDa1hjOUppQlJRR0lxL2F6aU91bkFxcURMN0I1Q0NOSjN1?=
 =?utf-8?B?VzNnMkRzeGxHOE9uZVd0aENWNExGVHIxWGg4T09hMXlCZlZwRld1bm1vR0Q0?=
 =?utf-8?B?UzhuSjMvZllFQWZXSVZJU241aDBSMGY3Z1JyMU02b3JXUk9CYS9LZkI4NEpE?=
 =?utf-8?B?NThWOHMyNC9jWS93VTRWcXVMNmxiQlA3NE5jOHNLcTZmTVJRQ0h3OWNvK1U2?=
 =?utf-8?B?Z2JNRzJhd2p5NG1PcU5rN2hDVllhWFhCZ3R5Zm1sMVhTV1ZCbklmcG1HUDVO?=
 =?utf-8?B?b1l3VzlxWmE2NVNJUEVhMi82N05ZVTNmUmJ3Z2loRGp5bFpPaERZM2luQWs4?=
 =?utf-8?B?Z0dVcmxDTFZNSEN3UmRTdXJvRFJhdmxyaXhhUm1icWdEb0JuMFNTYnorWVli?=
 =?utf-8?B?aG5NVDBYKy9YVDlkVG9zK0dyWWk0Z1g2Ryt6QjJZTkh4NVBkMitibDlWakE0?=
 =?utf-8?B?d2hQR2FHbjdCcThmQnBYdmRMNkZaRUNUZHBpSC85TUxURHZGNXovN0FUSFp3?=
 =?utf-8?B?MXFwa3VFNHJZcGo1STZyTlZDY1o4VzN3N1R4V0p5eFA4Y1p1NGRHbjVWcnd5?=
 =?utf-8?B?cEVGZWJQamFsL0dZbWxwUkNnc3dNaStncnRQZ0pCbGVQeURGdm82eVFZQmhD?=
 =?utf-8?B?emh4MWR0Q21XaGZyQUoreU5GNHlaS3VnNEF3QUlVMy92QkRuZnlUczdWQzBZ?=
 =?utf-8?B?Y2lNcTFQdW9hYUZ1QzFHRmRxcmRXVWExd29nZitzM3p2NXBDYnlnaisrNFlr?=
 =?utf-8?B?RldjRzdNRmFIdlpFUU40Tyt5a2plVjJFZlNQNDA2NzFwUW9ZMmZXQ3gxc0lM?=
 =?utf-8?B?Y3hhWTRqL0JvTEN4WHo0aEY3OXNDdDFENEVCWUR1SjdtdDQrNlNoNTA5NHV5?=
 =?utf-8?B?MVNQWFp2TlhCUGJIRS9lSG9Sa3g5bGp3UVdqdkNqdGJJSFI5UGFTczBiVkx0?=
 =?utf-8?B?L2lYc1pJdlUrTUZ0Si9oQWRLN3Y3OVFxeGdvTGVqLy83MXR2UThmeHZRa01G?=
 =?utf-8?B?ZnorTEtabFIzV1FEemx0QjJQT21rdjB6aU5iMzBoODBZbGd4bmxHMVJNekhm?=
 =?utf-8?B?K2hsekp0Ni9vcFlJeEQ1dHF3VEI4cllZQmJBMDczeHRDZGplM1NwNVNzY0JV?=
 =?utf-8?B?RlhwSndFNzBXRHNSOWZUL3NBNWwrMysyZzFudHl6aHdCTy9JMExiTUszdTZQ?=
 =?utf-8?B?RW9VS1VmcVpTa1cxK0VOWkdvM2Z6M2NGcW1XRGF3dWlLNnU1Q2lYZDNUUmZn?=
 =?utf-8?B?MFl5b29BZGVxamR5U0ltcDlLRzdGNHdtcnJBSXV4UkhIS2NENG5FOVFaVm0v?=
 =?utf-8?B?a0JoYnl2cnVxYVBGejltOTVUazI0T1ZiWnZTMzQ5ZkpIeW9oZVFEVFFzMjdh?=
 =?utf-8?B?clAybC95aCtiKzRXandBZS9qYjRZOHIwZ2J4eWE2Nk42SGx5YUxaQS9SdlNY?=
 =?utf-8?B?SWJ5THdQZlVwZTJZaVh6ek1LdDkwVUthTzRsYnBmaFJlVHE5YXZtQkYzb3kx?=
 =?utf-8?B?OUxsdzl1ZTNtUTFXUDZucmEvaUR0RDJvc3FyZktZYkQrTnl5UGRyb0loNHpE?=
 =?utf-8?B?bnF2M2pJQUQwQ1hySFFySHlYU2t4QzRTOENRS2ZxMjBZaFRWTHpwdWVnTk9O?=
 =?utf-8?B?WCtMSGN6Qjk0akxtSmRrWklvTm9CNm5STlNja1VwK242SCtkNndkK1dLL1g2?=
 =?utf-8?B?R0FsZVFZWGI4NXhoeDY5OE4zaWhtUFVFbTNjVGxuNFZ6L1hSMDJYYVpwQlUw?=
 =?utf-8?Q?2aRoqXPxbb034eovxa8IIDwRRRejS3/KKXJsbVWzhQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1d8c0de-13f1-45ad-486a-08d9aae5233a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3505.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 22:45:37.0447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n1KUtGq77vSvTI9puSV3n5yIR0zjy7P0eKUOJlcjsdQ2RTYZCn+U/yA4gjc0YM9cEQvgRKMnW9mu6Ufy+Nr3ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3137
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/7/21 2:17 PM, Kim Phillips wrote:
> On 10/7/21 12:28 PM, Jiri Olsa wrote:
>> On Mon, Oct 04, 2021 at 04:41:14PM -0500, Kim Phillips wrote:
>>> ---
>>>   tools/perf/util/evsel.c | 24 ++++++++++++++++++++++++
>>>   1 file changed, 24 insertions(+)
>>>
>>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>>> index b915840690d4..f8a9cbd99314 100644
>>> --- a/tools/perf/util/evsel.c
>>> +++ b/tools/perf/util/evsel.c
>>> @@ -2743,9 +2743,22 @@ static bool find_process(const char *name)
>>>       return ret ? false : true;
>>>   }
>>> +static bool is_amd(const char *arch, const char *cpuid)
>>> +{
>>> +    return arch && !strcmp("x86", arch) && cpuid && strstarts(cpuid, "AuthenticAMD");
>>> +}
>>> +
>>> +static bool is_amd_ibs(struct evsel *evsel)
>>> +{
>>> +    return evsel->core.attr.precise_ip || !strncmp(evsel->pmu_name, "ibs", 3);
>>> +}
>>> +
>>>   int evsel__open_strerror(struct evsel *evsel, struct target *target,
>>>                int err, char *msg, size_t size)
>>>   {
>>> +    struct perf_env *env = evsel__env(evsel);
>>> +    const char *arch = perf_env__arch(env);
>>> +    const char *cpuid = perf_env__cpuid(env);
>>>       char sbuf[STRERR_BUFSIZE];
>>>       int printed = 0, enforced = 0;
>>> @@ -2841,6 +2854,17 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
>>>               return scnprintf(msg, size, "wrong clockid (%d).", clockid);
>>>           if (perf_missing_features.aux_output)
>>>               return scnprintf(msg, size, "The 'aux_output' feature is not supported, update the kernel.");
>>> +        if (is_amd(arch, cpuid)) {
>>> +            if (is_amd_ibs(evsel)) {
>>
>> would single 'is_amd_ibs' call be better? checking on both amd and ibs
> 
> Good suggestion. If you look at the later patch in the
> BRS series, I have rewritten it to add the new
> AMD PMU like so:
> 
>   if (is_amd()) {
>       if (is_amd_ibs()) {
>           if (evsel->this)
>               return
>           if (evsel->that)
>               return
>       }
> +    if (is_amd_brs()) {
> +        if (evsel->this)
> +            return
> +        if (evsel->that)
> +            return
> +    }
>   }
> 
> Below is the full proposed replacement patch for patch 12
> of 13 of the BRS series.
> 
> Another option is to have the is_amd_{ibs,brs} functions
> call is_amd() themselves, so the if (evsel->) code could be
> unindented by one tab, would that be better?

No reply, so guessing not.

Arnaldo, can these two patches be applied please?

Thanks,

Kim