IronPort-SDR: RLLN5VBYeVoEeGAuMN33eheFkYjohIEV5IWfwE6dcykDjnsEuAHXSPlWDW2Sj0VUEgr7b/MJi3
 XI9D7S71jIABicSjb7K2maKWvyPk9RCOoBoBkB1MnqskhPx0ocPfcyMLbeEjL1S6XsDBIFo3u8
 HoSvITaYmoB8s35VIQPXa3v4CHc6+FO0MHYhaA3EGoccc0WAYfO52KXp75uM7BVseTmOum5gmK
 AHdeq4v/sRxpNKZhik8qMzf/QMz90c/BwB/OgC57vWcgLX/zWK+BnyDjvZfjzPEGUKlkvMXQUy
 pTX6JoZOtIg0gUQkpnAFrSGK
From:   Kelvin Cao <kelvin.cao@microchip.com>
To:     Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@linux.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Kelvin Cao <kelvin.cao@microchip.com>, <kelvincao@outlook.com>
Subject: [PATCH 2/2] Declare local array state_names as static
Date:   Thu, 18 Nov 2021 16:38:03 -0800
Message-ID: <20211119003803.2333-3-kelvin.cao@microchip.com>
In-Reply-To: <20211119003803.2333-1-kelvin.cao@microchip.com>
References: <20211119003803.2333-1-kelvin.cao@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

When a MRPC command is being executed, the function stuser_set_state()
will be called several times to set the command execution state.
During each run of stuser_set_state(), the local array state_names is
allocated and populated. The array contains a constant mapping of the
state enum values to the text strings, so repeated allocation and
initialization is just a wait of CPU cycles. Therefore, declare the
array as static.

See the link below for the discussion.

  https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/

Suggested-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
---
 drivers/pci/switch/switchtec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 6e2d6c5ea4b5..c36c1238c604 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -122,7 +122,7 @@ static void stuser_set_state(struct switchtec_user *stuser,
 {
 	/* requires the mrpc_mutex to already be held when called */
 
-	const char * const state_names[] = {
+	static const char * const state_names[] = {
 		[MRPC_IDLE] = "IDLE",
 		[MRPC_QUEUED] = "QUEUED",
 		[MRPC_RUNNING] = "RUNNING",
-- 
2.25.1